Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare Reproducible Builds #626

Merged
merged 1 commit into from
May 2, 2022
Merged

prepare Reproducible Builds #626

merged 1 commit into from
May 2, 2022

Conversation

hboutemy
Copy link
Member

@hboutemy hboutemy commented May 1, 2022

not sure this is sufficient, but at least this is required for Reproducible Builds...

@hboutemy
Copy link
Member Author

hboutemy commented May 1, 2022 •
edited
Loading

removing platform-dependant data from daemon common in common/src/main/resources/org/mvndaemon/mvnd/common/build.properties breaks tests...
I'm convinced that such things should not be at that place: perhaps only in client, because client is the only aspect that is native at the end?
we'll see that later...

ppalaga
ppalaga approved these changes May 1, 2022
View reviewed changes
Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @hboutemy !

@gnodet
Copy link
Contributor

gnodet commented May 2, 2022

#630 should help with the build.properties file.

@gnodet gnodet merged commit d3d83ba into master May 2, 2022
@hboutemy hboutemy deleted the rb branch May 2, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppalaga ppalaga ppalaga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hboutemy @gnodet @ppalaga