Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a mvnd.rawStreams property #719

Merged
merged 8 commits into from
Dec 16, 2022
Merged

Add a mvnd.rawStreams property #719

merged 8 commits into from
Dec 16, 2022

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Oct 16, 2022

No description provided.

@gnodet
Copy link
Contributor Author

gnodet commented Oct 16, 2022

Alternative proposal to #712.
The only drawback is that you can't specify -Dmvnd.rawStreams=false but only -Dmvnd.rawStreams which sets to value to true.

@gzm55
Copy link
Contributor

gzm55 commented Oct 17, 2022

Hi @gnodet I think this pr works fine, treating -Dmvnd.rawStreams as a zero parameter switch like --raw-streams for now, and i would close #712.
In the mean while, should we leave another issue to record some properties like mvnd.rawStreams or mvnd.serial can not accept false value.

@gnodet
Copy link
Contributor Author

gnodet commented Oct 17, 2022

Hi @gnodet I think this pr works fine, treating -Dmvnd.rawStreams as a zero parameter switch like --raw-streams for now, and i would close #712.

Good, I just need to fix the failing tests.

In the mean while, should we leave another issue to record some properties like mvnd.rawStreams or mvnd.serial can not accept false value.

Yes, please do.

@gnodet gnodet added this to the 1.0.0-m1 milestone Dec 16, 2022
@gnodet gnodet merged commit 5523673 into apache:master Dec 16, 2022
gnodet added a commit that referenced this pull request Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants