Reset system properties after calling event syps #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Event spies may want to read system properties, which will fail if they are reset too early. This change makes the behavior consistent with regular Maven.
|
We have put a hacky workaround into our extension (capturing the system properties early in the build), but it would be great if you could merge this fix. |
|
You meant this one @guylabs? |
|
@ppalaga Yes exactly :) All done already. Thanks for checking back on this! |
gnodet
pushed a commit
that referenced
this pull request
Jan 6, 2023
Event spies may want to read system properties, which will fail if they are reset too early. This change makes the behavior consistent with regular Maven.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Event spies may want to read system properties, which will fail if they are reset too early. This change makes the behavior consistent with regular Maven.