Run client connection handler inside new thread, fixes #798 #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
psiroky
commented
Mar 7, 2023
psiroky
commented
- same as [0.10.x] Run client connection handler inside new thread, fixes #798 #799 but for master branch
- I quickly tested this locally and master was suffering from the same thread leak issue as the 0.10.x. If we decided this is the solution, then it should be applied to master as well
* ubuntu-18.04 image is now deprecated and there are brownout periods being introduced where the builds are failing * see actions/runner-images#6002 for more details
psiroky
commented
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.