[MPLUGIN-442] Generate goal documentation leveraging Sink API #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwin
commented
Sep 7, 2023
...n-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/GoalRenderer.java
Show resolved
Hide resolved
|
Will happily review, leave me a couple of days... |
Drop XDoc intermediate format
kwin
force-pushed
the
feature/remove-xdoc-intermediate-format
branch
from
6e1504a
to
ca6df87
Compare
michael-o
requested changes
Sep 20, 2023
maven-plugin-tools-api/src/main/java/org/apache/maven/tools/plugin/util/PluginUtils.java
Show resolved
Hide resolved
...plugin/src/main/java/org/apache/maven/plugin/plugin/report/AbstractPluginReportRenderer.java
Show resolved
Hide resolved
...eport-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginOverviewRenderer.java
Outdated
Show resolved
Hide resolved
...eport-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginOverviewRenderer.java
Show resolved
Hide resolved
...eport-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginOverviewRenderer.java
Show resolved
Hide resolved
...eport-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginOverviewRenderer.java
Show resolved
Hide resolved
...n-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginReport.java
Show resolved
Hide resolved
...n-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/GoalRenderer.java
Outdated
Show resolved
Hide resolved
...n-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/GoalRenderer.java
Show resolved
Hide resolved
|
@michael-o Any more comments on the anchors being generated? |
michael-o
reviewed
Sep 27, 2023
michael-o
requested changes
Oct 3, 2023
...n-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/GoalRenderer.java
Show resolved
Hide resolved
kwin
force-pushed
the
feature/remove-xdoc-intermediate-format
branch
from
e677aa9
to
a92577d
Compare
michael-o
reviewed
Oct 5, 2023
...n-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/GoalRenderer.java
Outdated
Show resolved
Hide resolved
kwin
force-pushed
the
feature/remove-xdoc-intermediate-format
branch
from
205de0e
to
f6dc034
Compare
michael-o
reviewed
Oct 7, 2023
...n-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/GoalRenderer.java
Outdated
Show resolved
Hide resolved
|
See also checkstyle/checkstyle#13016 |
kwin
force-pushed
the
feature/remove-xdoc-intermediate-format
branch
from
41ca383
to
1696e35
Compare
Comment on lines
+277
to
+279
| if (StringUtils.isNotEmpty(parameter.getDeprecated())) { | ||
| String deprecated = getXhtmlWithValidatedLinks(parameter.getDescription(), context); | ||
| description = format("parameter.deprecated", deprecated); |
There was a problem hiding this comment.
@kwin @michael-o
Is it intended - we check parameter.getDeprecated() but use parameter.getDescription()?
We lost here deprecated reason ... only deprecated label with standard description is printed.
There was a problem hiding this comment.
That is a copy-paste mistake. It is supposed to print the deprecation text.
There was a problem hiding this comment.
The removed Xdoc generator had it right. @slawekjaranowski Please file an issue. We need to fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop XDoc intermediate format