MSHADE-363 add ReproducibleResourceTransformer to restore compatibility #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
reviewed
May 12, 2020
| import java.util.List; | ||
|
|
||
| /** | ||
| * Copy of original interface necessary to MSHADE-363_old-plugin IT. |
There was a problem hiding this comment.
This comment gives me the feeling that this interface exists for the mentioned IT only. Does it?
There was a problem hiding this comment.
oh, I switched src/main/java/.../ReproducibleResourceTransformer.java content with src/test/java/.../ReproducibleResourceTransformer.java
will replace files...
rmannibucau
approved these changes
May 12, 2020
There was a problem hiding this comment.
Agree with @michael-o that the comment should be more "production" oriented but functionally this is exactly what we need, thanks a lot @hboutemy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MSHADE-363