-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MSITE-1010] Add documentation how site repository inheritance #194
Conversation
Thanks for the review. Requested changes done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yet another issue. The problem is not a repository, we do not even have that notion for sites. It is solely about site deployment vs local generation -- as laid out in the JIRA issue. We shouldn't try to introduce the term site repository. I'll review our code to make wording better.
See: #195 |
I get your point and totally understand it. I updated the PR to avoid the term repository, changed the name of the page (and therefore the menu entry) to distribution management and also fixed some grammar mistakes/bad wording. Would you please have another look? |
Will review tomorrow again. |
@Bukama I have added a few improvements, please have a look. |
Thanks! I like them! |
Co-authored-by: Michael Osipov <michaelo@apache.org> This closes apache#194
Co-authored-by: Michael Osipov <michaelo@apache.org> This closes #194
Proposed commit message:
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MSITE-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MSITE-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.