[MNG-5771] Document all classloaders used in Maven #338
Conversation
Clarify differences between Core and Build extensions
| @@ -0,0 +1,46 @@ | |||
| /* | |||
There was a problem hiding this comment.
What are these new files doing here? Maybe drawing some sort of diagram or something?
There was a problem hiding this comment.
Yes, exactly, they have this format: https://plantuml.com/class-diagram and are converted during build to SVG. Also they are referenced in modified APT documents e.g. in https://github.com/apache/maven-site/pull/338/files#diff-3a01086d28efd2b3cb838d37d2efcafa96e65044d0b09a6826b6a5ca3b54a45aR92.
|
Starter comment: could we just convert any exotic formatted document to something supported by modern tools when we touch them? Like Markdown or ADoc (depdending on complexity and requirements of documentation)? |
I don't think this should be included in PRs which change something else. Otherwise the diff is no longer visible. It needs to be separately done either before or after. Also I miss the automated conversion from |
|
Wow, yet another Maven Component that depends on plexus-container-default... 🍺 |
|
It might be worthwhile to write a general purpose .apt to markdown converter. However that should not be part of this PR. As to why we have these exotic special purpose things, a lot of it is is simply that this code goes back 20 years and no such de facto standard tool existed back then. |
|
@cstamas Any further remarks before I go ahead and merge? |
Clarify differences between Core and Build extensions