Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUREFIRE-2117] Include package, outer classes in XML report for @Nested #568

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

andpab
Copy link
Contributor

@andpab andpab commented Oct 3, 2022

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@elharo
Copy link
Contributor

elharo commented Dec 15, 2022

Run actions/upload-artifact@v3
With the provided path, there will be 8281 files uploaded
Starting artifact upload
For more detailed logs during the artifact upload process, enable step-debugging: https://docs.github.com/actions/monitoring-and-troubleshooting-workflows/enabling-debug-logging#enabling-step-debug-logging
Artifact name is valid!
Error: Artifact path is not valid: /this is: a test_surefire-1617/log.txt. Contains the following character: Colon :

Invalid characters include: Double quote ", Colon :, Less than <, Greater than >, Vertical bar |, Asterisk *, Question mark ?, Carriage return \r, Line feed \n

@andpab andpab force-pushed the SUREFIRE-2117 branch 2 times, most recently from c864548 to 23e1e60 Compare December 19, 2022 15:15
@andpab
Copy link
Contributor Author

andpab commented Dec 19, 2022

@elharo I fixed the artifact upload in SUREFIRE-2136 and I also fixed the cause of the failed IT under JDK 18 in SUREFIRE-2135. Slawomir just merged both to master, I then rebased this PR to master, so the checks for this PR have all passed now.

@andpab andpab force-pushed the SUREFIRE-2117 branch 3 times, most recently from 8044991 to acb2fd6 Compare December 22, 2022 12:12
@slawekjaranowski slawekjaranowski merged commit 4f4ac97 into apache:master Dec 28, 2022
@andpab andpab deleted the SUREFIRE-2117 branch December 29, 2022 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants