Javadoc fixes #1198
Merged
Javadoc fixes #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elharo
approved these changes
Jul 5, 2023
api/maven-api-core/src/main/java/org/apache/maven/api/Type.java
Outdated
Show resolved
Hide resolved
api/maven-api-core/src/main/java/org/apache/maven/api/Type.java
Outdated
Show resolved
Hide resolved
| @@ -23,9 +23,9 @@ | |||
| public interface Dependency extends Artifact { | |||
There was a problem hiding this comment.
Realizing now this inheritance hierarchy is wonky. This suggests a Dependency is an artifact, which isn't true. Nothing to do about that in this PR of course, but I wanted to call it out while I'm thinking about it.
There was a problem hiding this comment.
I think this is true in this context. This is unrelated to the model's dependency list.
Here, the Dependency is the resolved Artifact that come from a DependencyCoordinate. This is more related to the dependency collection and artifact resolution. The DependencyCoordinate is what maps closely to the model's Dependency.
elharo
reviewed
Jul 5, 2023
api/maven-api-core/src/main/java/org/apache/maven/api/Type.java
Outdated
Show resolved
Hide resolved
api/maven-api-core/src/main/java/org/apache/maven/api/Type.java
Outdated
Show resolved
Hide resolved
api/maven-api-core/src/main/java/org/apache/maven/api/Type.java
Outdated
Show resolved
Hide resolved
api/maven-api-core/src/main/java/org/apache/maven/api/Type.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.