Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-6410] Clean suggestion on build resume. #166

Closed
wants to merge 1 commit into from

Conversation

splatch
Copy link
Contributor

@splatch splatch commented May 11, 2018

Make sure that resume suggestion contains a valid value for restarting the build, as same artifact name might occur in different places of multi-module project, it is necessary to check if there is conflict in name.

By this way returned suggestion will always be correct and less experienced developers will not get confused with it.

JIRA issue: https://issues.apache.org/jira/browse/MNG-6410.
A extra note, this pull request depends on another pull #165 - for MNG-6028, which changes the same line, both commits are included in this PR.

@hboutemy
Copy link
Member

I'm not convinced by MNG-6028: can you create the patch for MNG-6410 without MNG-6028, please?

@splatch
Copy link
Contributor Author

splatch commented May 17, 2018

Sure, no problem - I will just strip this commit and update PR. The 6028 was open for some time so I decided to work on it while I was around. All CLI parameters are available in cliRequest. Whole command may be printed with -rf, if there will be such requirement.

@splatch
Copy link
Contributor Author

splatch commented May 18, 2018

Sure, no problem - I will just strip this commit and update PR. The 6028 was open for some time so I decided to work on it while I was around.

@splatch splatch force-pushed the MNG-6410 branch 3 times, most recently from c4e4e6a to 2540e23 Compare May 18, 2018 00:46
asfgit pushed a commit that referenced this pull request May 18, 2018
@asfgit asfgit closed this in 864d180 May 20, 2018
pzygielo pushed a commit to pzygielo/maven that referenced this pull request Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants