[MNG-8120] Refactor ModelBuilder and ProjectBuilder #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnodet
force-pushed
the
project-builder
branch
9 times, most recently
from
c5d7d81
to
2ac2957
Compare
# Conflicts: # maven-api-impl/src/main/java/org/apache/maven/internal/impl/model/DefaultModelBuilder.java
gnodet
force-pushed
the
project-builder
branch
8 times, most recently
from
b9a4125
to
2b5c901
Compare
# Conflicts: # maven-api-impl/src/main/java/org/apache/maven/internal/impl/model/DefaultModelBuilder.java
# Conflicts: # maven-api-impl/src/main/java/org/apache/maven/internal/impl/model/DefaultModelBuilder.java
gnodet
force-pushed
the
project-builder
branch
from
2b5c901
to
88cf024
Compare
# Conflicts: # api/maven-api-core/src/main/java/org/apache/maven/api/services/ModelBuilderResult.java
gnodet
force-pushed
the
project-builder
branch
from
41af7cf
to
483818b
Compare
gnodet
force-pushed
the
project-builder
branch
from
45bcde7
to
fb34cbb
Compare
gnodet
force-pushed
the
project-builder
branch
from
fb34cbb
to
6d78b75
Compare
gnodet
force-pushed
the
project-builder
branch
from
df76dfc
to
be716a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
ModelBuilderandProjectBuilder.With the introduction of the build pom and raw -> build pom transformation, the construction of the effective poms in two steps become very problematic. Over the time, multiple caches have been added to the ProjectBuilder and ModelBuilder related classes which are often redundant.
This PR thus changes things and move the recursive construction of the models fully into the
ModelBuilderin a single call. When building build poms, a first step is done by parsing the file models from the root, then building all needed effective models from those. All the inference can be cleanly done because the builder has all the file models ready. The result will be used by theProjectBuilderto build the projects.IT PR: apache/maven-integration-testing#357