[MNG-7541] Implement powershell command #878

JurrianFahner · 2022-11-19T15:37:08Z

Following this checklist to help us incorporate your
contribution quickly and easily:

Make sure there is a JIRA issue filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
Each commit in the pull request should have a meaningful subject line and body.
Format the pull request title like [MNG-XXX] SUMMARY, where you replace MNG-XXX
and SUMMARY with the appropriate JIRA issue. Best practice is to use the JIRA issue
title in the pull request title and in the first line of the commit message.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Run mvn clean verify to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.

apache-maven/src/assembly/shared/mvnvalidate.ps1

… variable.

michael-o · 2022-11-19T20:08:32Z

Has this been tested with Windows PowerShell or PowerShell 7?

JurrianFahner · 2022-11-19T21:23:50Z

Has this been tested with Windows PowerShell or PowerShell 7?

Mainly with powershell 7.3.0, but now also with powershell 5.1.22621.608.

The test is done by running mvn clean package on a simple project. It will not cover all use-cases for the scripts that have been changed. Is there an example project to check all of these?

michael-o · 2022-11-19T21:26:30Z

This is at least what I have, although I work from Windows Terminal with PowerShell 7 only:

C:\Users\mosipov> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.19041.1682
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.1682
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

I'd expect that on a Windows CI Agent only the Windows PS will be used. Thus, this should be our minimum requirement.

michael-o · 2022-11-19T21:27:09Z

Try the Maven Core ITs with this. Make sure that .cmd isn't included, just in case.

JurrianFahner · 2023-02-07T21:32:42Z

The CoreIT tests have run well.

JurrianFahner · 2023-03-17T20:04:39Z

@michael-o From my perspective this PR is ready. What's your perspective on this position?

michael-o · 2023-03-17T20:16:16Z

@michael-o From my perspective this PR is ready. What's your perspective on this position?

I want to get back to this end of month.

JurrianFahner · 2023-04-15T11:25:17Z

@michael-o Gentle reminder

JurrianFahner · 2023-09-21T20:23:30Z

@Giovds @michael-o This branch contains the latest improvements from #982.

apache-maven/src/assembly/maven/bin/mvnDebug.ps1

apache-maven/src/assembly/shared/init.ps1

apache-maven/src/assembly/shared/mvnvalidate.ps1

apache-maven/src/assembly/shared/run.ps1

apache-maven/src/assembly/shared/validate.ps1

Giovds · 2023-10-13T10:04:03Z

apache-maven/src/assembly/maven/bin/mvnDebug.ps1

+#>
+
+# set title
+$Host.UI.RawUI.WindowTitle = $MyInvocation.MyCommand


This probably has the same 'issue' as as 3.x script: #982 (comment)?

Giovds · 2023-10-13T10:20:18Z

apache-maven/src/assembly/shared/init.ps1

@@ -0,0 +1,83 @@
+# ==== END VALIDATION ====
+
+$CLASSWORLDS_CONF = "$MAVEN_HOME\bin\m2.conf"


Should this be part of mvnlauncher.ps1 as it is never used in this file?

I'd keep it identical to init.cmd.

apache-maven/src/assembly/shared/validate.ps1

Giovds

It would be nice to fix the command terminal title, the rest LGTM

JurrianFahner · 2023-10-14T21:16:39Z

It would be nice to fix the command terminal title, the rest LGTM

@Giovds I've created an issue to improve the command terminal title: https://issues.apache.org/jira/browse/MNG-7907

The description is a little bit rough right now and needs some extra refinement.

apache-maven/src/assembly/maven/bin/mvnDebug.ps1

michael-o · 2024-04-15T08:34:17Z

apache-maven/src/assembly/shared/init.ps1

@@ -0,0 +1,83 @@
+# ==== END VALIDATION ====
+
+$CLASSWORLDS_CONF = "$MAVEN_HOME\bin\m2.conf"


I'd keep it identical to init.cmd.

michael-o · 2024-04-15T08:37:50Z

apache-maven/src/assembly/shared/init.ps1

+  if (Test-Path $jvm_config) {
+    return $env:MAVEN_OPTS + " " + -Join (Get-Content $jvm_config)
+  }
+  return $env:MAVEN_OPTS


That is not correct. If the file is empty then it is empty. See approach in init.

I don't understand your comment.

You are joining the content of the jvm.config file with MAVEN_OPTS variable in one guy. From a caller's perspective that should not be done and it is not obvious from where the config comes. Look at the original files, they do not merge them.

michael-o · 2024-04-15T08:38:00Z

apache-maven/src/assembly/shared/init.ps1

+  }
+}
+
+$MAVEN_OPTS = (RetrieveContentsJvmConfig $basedir)


michael-o · 2024-04-15T08:40:56Z

apache-maven/src/assembly/shared/mvnvalidate.ps1

+# check if maven command exists
+if (-not (Test-path "$MAVEN_HOME\bin\mvn.ps1")) {
+    Write-Error -Message "Maven command ($MAVEN_HOME\bin\mvn.ps1) cannot be found" -ErrorAction Stop
+}


I wonder whether this is a relic from the past. In mvnvalidate this check isn't present and this file is part of mvn/mvn.cmd/mvn.ps1. How can this fail?`

If mvn.ps1 or mvn.cmd is removed or not accessible.

But it is indeed a corner case, shall we remove it?

But how can this happen at all? This is a chicken-and-egg issue. This block is part of the merged mvn.ps1. If the file is not present that check will never happen, no? This confuses me.

apache-maven/src/assembly/shared/validate.ps1

[MNG-7541] Implement powershell build

29283a1

michael-o requested changes Nov 19, 2022

View reviewed changes

apache-maven/src/assembly/shared/mvnvalidate.ps1 Outdated Show resolved Hide resolved

[MNG-7541] Change MAVEN_HOME from environment variable to an internal…

79ad973

… variable.

[MNG-7541] Make the powershell also work for powershell 5

04bd68c

Merge branch 'master' of github.com:apache/maven

b19b264

JurrianFahner requested a review from michael-o February 11, 2023 22:17

michael-o removed their request for review February 20, 2023 22:33

Merge branch 'master' of github.com:apache/maven

fc5b4f1

JurrianFahner mentioned this pull request Sep 20, 2023

[MNG-7541] Implement powershell mvn command #982

Open

9 tasks

JurrianFahner and others added 3 commits September 21, 2023 20:50

Merge branch 'apache:master' into master

864b82b

Merge branch 'master' of github.com:JurrianFahner/maven

e72007a

[MNG-7541] Bring powershell implementation more in line with cmd

13ec9cd

JurrianFahner requested a review from michael-o September 21, 2023 20:24

michael-o requested changes Sep 21, 2023

View reviewed changes

JurrianFahner and others added 4 commits September 22, 2023 23:26

[MNG-7541] Change format of the license header and rename to jvm_config

e724f4a

Merge branch 'apache:master' into master

d9eb02b

Merge branch 'master' of github.com:JurrianFahner/maven

7c17505

[MNG-7541] Align the debug address description with implementation

c61621d

Giovds reviewed Oct 13, 2023

View reviewed changes

apache-maven/src/assembly/shared/validate.ps1 Show resolved Hide resolved

Giovds approved these changes Oct 13, 2023

View reviewed changes

hboutemy force-pushed the master branch from a075afa to 6e50886 Compare March 24, 2024 21:16

JurrianFahner requested a review from michael-o April 14, 2024 08:43

michael-o requested changes Apr 15, 2024

View reviewed changes

[MNG-7541] Set default address to localhost:8080

43ca770

michael-o self-requested a review April 28, 2024 09:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MNG-7541] Implement powershell command #878

[MNG-7541] Implement powershell command #878

JurrianFahner commented Nov 19, 2022 •

edited

Loading

michael-o commented Nov 19, 2022

JurrianFahner commented Nov 19, 2022

michael-o commented Nov 19, 2022

michael-o commented Nov 19, 2022

JurrianFahner commented Feb 7, 2023 •

edited

Loading

JurrianFahner commented Mar 17, 2023

michael-o commented Mar 17, 2023

JurrianFahner commented Apr 15, 2023

JurrianFahner commented Sep 21, 2023

Giovds Oct 13, 2023

Giovds Oct 13, 2023

michael-o Apr 15, 2024

Giovds left a comment

JurrianFahner commented Oct 14, 2023 •

edited

Loading

michael-o Apr 15, 2024

michael-o Apr 15, 2024

JurrianFahner Apr 16, 2024

michael-o Apr 28, 2024

michael-o Apr 15, 2024

michael-o Apr 15, 2024

JurrianFahner Apr 16, 2024

michael-o Apr 28, 2024

		@@ -0,0 +1,83 @@
		# ==== END VALIDATION ====

		$CLASSWORLDS_CONF = "$MAVEN_HOME\bin\m2.conf"

[MNG-7541] Implement powershell command #878

Are you sure you want to change the base?

[MNG-7541] Implement powershell command #878

Conversation

JurrianFahner commented Nov 19, 2022 • edited Loading

michael-o commented Nov 19, 2022

JurrianFahner commented Nov 19, 2022

michael-o commented Nov 19, 2022

michael-o commented Nov 19, 2022

JurrianFahner commented Feb 7, 2023 • edited Loading

JurrianFahner commented Mar 17, 2023

michael-o commented Mar 17, 2023

JurrianFahner commented Apr 15, 2023

JurrianFahner commented Sep 21, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Giovds left a comment

Choose a reason for hiding this comment

JurrianFahner commented Oct 14, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JurrianFahner commented Nov 19, 2022 •

edited

Loading

JurrianFahner commented Feb 7, 2023 •

edited

Loading

JurrianFahner commented Oct 14, 2023 •

edited

Loading