Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-7644] Fix version comparison ( .X1 < -X2 for any string qualifier x ), 4.0.x branch #932

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

sultan
Copy link
Contributor

@sultan sultan commented Dec 20, 2022

The current version parser does not treat .RC and -RC correctly:
actual : 1.0.0.RC1 > 1.0.0-RC2
expected : 1.0.0.RC1 < 1.0.0-RC2
 
because RC1 < RC2
how to fix : place a list item before qualifier

as a consequence for any string qualifier x:
previously:

  • 1.0.0.X1 > 1.0.0-X2
  • 1.0.X < 1.0.0.X

now:

  • 1.0.0.X1 < 1.0.0-X2
  • 1.0.X == 1-X == 1.0.0.X

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY,
    where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
  • Also format the first line of the commit message like [MNG-XXX] SUMMARY.
    Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@sultan sultan force-pushed the dot-4.0.x branch 3 times, most recently from c77cfd3 to f27b560 Compare December 21, 2022 09:36
@sultan sultan changed the title [MNG-7644] Fix version comparison ( .RC1 < -RC2 ), 4.0.x branch [MNG-7644] Fix version comparison ( .X1 < -X2 for any string qualifier x ), 4.0.x branch Dec 21, 2022
@sultan sultan force-pushed the dot-4.0.x branch 3 times, most recently from 4d2c486 to ba9efb0 Compare December 21, 2022 10:13
michael-o pushed a commit to sultan/maven that referenced this pull request Dec 21, 2022
@michael-o
Copy link
Member

@sultan Running tests now. I have applied small improvements to Javadoc. Kindly replicate to other PRs as well.

@sultan
Copy link
Contributor Author

sultan commented Dec 21, 2022

@sultan Running tests now. I have applied small improvements to Javadoc. Kindly replicate to other PRs as well.

neat!

@asfgit asfgit merged commit 35c81be into apache:master Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants