Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

METRON-2360 BRO-PLUGIN: does not build with 3.2.1 #48

Closed
wants to merge 2 commits into from

Conversation

ottobackwards
Copy link
Contributor

@ottobackwards ottobackwards commented Sep 17, 2020

Cleanup namespace and includes change to newer zeek.

NOTE: new zeek does not like our pcaps used with docker testing.


This change is Reviewable

@JonZeolla
Copy link
Member

Tests are broken because diff isn't installed in our zeek docker image; we need to add diffutils. Since it's only required for the tests which are run during zkg install, I suggest throwing it in the zkg RUN block. After doing that I was able to get e2e all the way to the expected error due to the fix for zeek/zeek#977:

1258563753.320650 fatal error: failed to read a packet from /root/data/example-traffic/exercise-traffic.pcap: truncated dump file; tried to read 1434 captured bytes, only got 415

Copy link
Member

@JonZeolla JonZeolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 visual inspection and tested e2e with 3.2.1 and 3.1.5

@asfgit asfgit closed this in 92b85e5 Sep 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants