This repository has been archived by the owner on May 12, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 507
METRON-1741 Move REPL Port of Profiler to Separate Project #1170
Closed
nickwallen
wants to merge
25
commits into
apache:feature/METRON-1699-create-batch-profiler
from
nickwallen:METRON-1741
Closed
METRON-1741 Move REPL Port of Profiler to Separate Project #1170
nickwallen
wants to merge
25
commits into
apache:feature/METRON-1699-create-batch-profiler
from
nickwallen:METRON-1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to have so much data
This reverts commit 14bee4f.
…-profiler' into METRON-1714
…-profiler' into METRON-1714
…-profiler' into METRON-1741
…-profiler' into METRON-1741
…-profiler' into METRON-1741
…-profiler' into METRON-1741
I ran this up in full dev and went through the testing instructions. Everything worked great. +1 |
asfgit
pushed a commit
that referenced
this pull request
Sep 4, 2018
Thanks for the review! This has been merged into the feature branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates out the Profiler code specific to the port which runs in the Stellar REPL into its own project. This also creates a separate tarball and RPM for the Profiler in the Stellar REPL.
Since there will soon be 3 ports of the Profiler; Storm, the REPL, and Spark, I want to separate out the code base so that it cleanly delineate which code is used by which port. Soon we should have the following projects.
PROFILE_GET
, etc.This is dependent on the following PRs . By filtering on the last two commits, this PR can be reviewed before the others are reviewed and merged.
Testing
Spin-up the development environment.
Validate the development environment by ensuring alerts are visible within the Alerts UI and that the Metron Service Check in Ambari passes.
Launch the REPL and follow the instructions in the Profiler README to create and execute a profile in the REPL.
Follow the instructions in the README to deploy the same profile in Storm. Ensure that you can retrieve values from HBase using
PROFILE_GET
.Pull Request Checklist