METRON-1758: Add support for Ansible 2.6 in dev

[JonZeolla]

Contributor Comments

This changes so we support any version of Ansible, v2.4.0 and newer, and displays a clean message if the version of ansible being used is older than that. 2.4 was released in September of 2017 and is the lowest version that also lets us get rid of these deprecation warnings.

This is on hold for the moment, as reliably checking the version of ansible pre-syntax checking/failure doesn't have a supported approach.

Testing

To test, spin up full-dev with any version of ansible < 2.4.0 and expect failure, then upgrade to => 2.4.0 and expect success.

Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

• Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
• Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
• Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

• Have you included steps to reproduce the behavior or problem that is being changed or addressed?

• Have you included steps or a guide to how the change may be verified and tested manually?

• Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:

  mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
  

• Have you written or updated unit tests and or integration tests to verify your changes?

• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

• Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

• Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:

  cd site-book
  mvn site
  

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

[JonZeolla]

This is ready for review. At least one person has reported an issue with running up master on Ansible 2.0.0.2, which is what we currently point people to as an option, so this needs to be modified no matter what.

There is still no fix for checking the version of ansible a client is using in a situation where the yaml doesn't parse correctly for that version, given the current setup of our playbooks. Reference

[nickwallen]

I was able to spin-up Full Dev with Ansible 2.5.0.0. What versions have you specifically tested this on?

$ ansible --version
ansible 2.5.0
  config file = /Users/nallen/tmp/metron-pr1179/metron-deployment/development/centos6/ansible.cfg
  configured module search path = [u'/Users/nallen/tmp/metron-pr1179/metron-deployment/ansible/extra_modules']
  ansible python module location = /usr/local/lib/python2.7/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.15 (default, Jun 26 2018, 19:46:20) [GCC 4.2.1 Compatible Apple LLVM 9.1.0 (clang-902.0.39.1)]

Also, we should probably give a shout-out to the Dev list mentioning that only 2.4.0+ will work after this PR goes in.

[JonZeolla]

I have tested with 2.4.0, 2.5.0, and 2.6.3. I agree, we should announce to dev and maybe even to user since I know some people use full-dev for a poc.

[JonZeolla]

I also tested with 2.2.2.0 to ensure it fails, but it fails in the unclean way as noted above.

[nickwallen]

Nice! Very thorough. :)

I am a +1 pending a positive outcome to a mailing list discussion as you suggest.

Thanks for this contribution.

[JonZeolla]

https://lists.apache.org/thread.html/49c12cedbdd750146cd2f16c37693cc363bc570984810e6de15deaf6@%3Cdev.metron.apache.org%3E

[justinleet]

I'm also +1 and also commented on the thread in support of merging.

[JonZeolla]

TODO: This section should be removed since we're using the callback plugin now.

[JonZeolla]

Did some trivial cleanups.