METRON-1936: Cypress fails when trying to parse double quotes

[sardell]

Contributor Comments

Double quotes that are used inside the parser list component are causing a parsing issue for Cypress, even if you switch them out with html encoded double quotes.

Testing

You can reliably test against PR #1275

Clone the base branch from that PR and run npm run cypress:ci. You will see all the tests fail.

Clone this PR branch, merge into 1275's base branch and again run npm run cypress:ci. This time the tests will pass.

If you want to see the cryptic error message, you can also run ng serve --aot and then npx cypress open and run cypress' tests from its UI. There, you can see the error message in the Cypress tools console.

Future considerations

I didn't see any explanations for this issue in my research, but Cypress is now out of beta, so perhaps this issue has been silently addressed. It's worth looking into as a separate task, but this is a very quick, minimally invasive fix for now.

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

• Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
• Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
• Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

• Have you included steps to reproduce the behavior or problem that is being changed or addressed?

• Have you included steps or a guide to how the change may be verified and tested manually?

• Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:

  mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
  

• Have you written or updated unit tests and or integration tests to verify your changes?

• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

• Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

• Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:

  cd site-book
  mvn site
  

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

[merrimanr]

I was able to get a passing test in #1275 after applying this change. +1 pending we figure out the travis failure.

[sardell]

I've tried to reproduce this failure but to no avail. It was resolved by simply re-running the Travis build, and I'm pretty confident my changes here wouldn't cause such a failure.

[merrimanr]

I agree, I don't think that was introduced here. +1