Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
METRON-1958: Optimize Cypress to use best practices #1317
Link to the original ASF JIRA ticket: https://jira.apache.org/jira/browse/METRON-1958
As described in the ticket, we have a few anti-patterns in place right now in regard to our Cypress configuration. Through local testing, I believe this has led to the recent Travis failures in Pull Requests like #1308 and #1275.
Clone either #1308 and #1275 locally. From the command line, navigate to metron-interface/metron-alerts from the root of the project. Install npm dependencies by running
Once you've verified failure on either on of the PRs mentioned above, clone this PR locally. Merge it into #1308 or #1275, run
The Cypress team recommends the use of the
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:
For code changes:
For documentation related changes:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
Has this been tested in full dev? The
I am going to test in full dev now and will report back.
I confirmed this in full dev. The Alerts UI fails to start unless you add
I have a post-merge comment - I really like this change:
I've used this pattern for integration testing before and it makes repeat runs more reliable, ie by cleaning up before the tests run, if you cancel prior to tests finishing you are still able to re-run without worrying about old state. Also, if you run into a test failure, now you have data post-test run that you can dig into and investigate without modifying your test infrastructure ad-hoc.