Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

METRON-1965: Knox should work on a multi-node installation #1320

Closed
wants to merge 1 commit into from

Conversation

@merrimanr
Copy link
Contributor

merrimanr commented Jan 8, 2019

Contributor Comments

This PR fixes a few bugs that are exposed when a Knox Gateway is not installed on the same host as Metron.

Changes Included

  • The Metron Knox installed flag is now only written when Metron Knox is actually installed. Before it was being written when a Metron Client is installed, Metron Knox is enabled and Knox is not been present on that host yet.
  • The Metron Client component now installs the various Metron scripts and binaries.
  • The Knox host is now added to the Metron SSO whitelist.

Testing

This can be tested in full dev by just verifying Knox with Metron still works. It should also be tested in a multi-node environment where Knox and Metron are not colocated.

Other Considerations

I can't think of any reason we would not want the Metron Client component to install the various Metron packages but let me know if anyone disagrees.

Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

  • Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
  • Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

  • Have you included steps to reproduce the behavior or problem that is being changed or addressed?

  • Have you included steps or a guide to how the change may be verified and tested manually?

  • Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:

    mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
    
  • Have you written or updated unit tests and or integration tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

  • Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:

    cd site-book
    mvn site
    

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

@anandsubbu

This comment has been minimized.

Copy link
Contributor

anandsubbu commented Jan 8, 2019

+1 works as advertised.

Validated the changes on a 12-node setup, with the Knox gateway and metron being present on different nodes.
Verified that the swagger UI, alerts UI and mgmt UI comes up fine upon authenticating at the Knox SSO login page.

Thank you for the fix @merrimanr !

@asfgit asfgit closed this in 2c99257 Jan 9, 2019
JonZeolla added a commit to JonZeolla/metron that referenced this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.