METRON-2058: UI: Actions -> Add to Alert can still be selected from dropdown when no alerts are selected.

[ruffle1986]

Contributor Comments

Link to the original ASF Jira: https://issues.apache.org/jira/browse/METRON-2058

You can perform batch operations on alerts in the alerts ui. once you have selected one or multiple alerts (by clicking on the checkbox on the right) you can perform these batch operations. In order to do that you have to open the "Actions" dropdown below the alerts list and on the right side of the screen.

Previously, when you clicked on "Add to alert", it opened the right pane even though it was disabled because there were no alerts selected (and it made it clear by showing the proper cursor icon).

From now on, if the user clicks on a disabled element within the dropdown, nothing happens.

Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

• Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
• Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
• Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

• Have you included steps to reproduce the behavior or problem that is being changed or addressed?

• Have you included steps or a guide to how the change may be verified and tested manually?

• Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:

  mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
  

• Have you written or updated unit tests and or integration tests to verify your changes?

• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

• Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

• Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:

  cd site-book
  mvn site
  

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

[tiborm]

The only thing I would change is the variable name 'e' standing for events. Using e is pretty common however in our code base there is just 3 occurrence for it (alongside with 13 'event' and 96 '$event').

Otherwise, it seems pretty straight forward to me. +1 (unbinding)

[ruffle1986]

@tiborm Good point. Renamed it from e to event

[sardell]

Tested with full dev. Works as described above. Nice catch! +1.