This repository has been archived by the owner on May 12, 2021. It is now read-only.
METRON-1275: Fix Metron Documentation #833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know whether my +1 is actually relevant, but here it goes: +1. Looks good to me :) |
|
Yes @lvets your +1 is definitely relevant. I wish more community members would review PRs. |
nickwallen
reviewed
Nov 7, 2017
| -sp 24 \ | ||
| -snt 24 \ | ||
| -k $BROKERLIST \ | ||
| -ksp SASL_PLAINTEXT \ |
There was a problem hiding this comment.
This will only work in a Kerberized environment, no? Should that be called out?
There was a problem hiding this comment.
Oops, sorry that's already how the docs were. I wasn't following what you were doing here. All you're doing is a reformat. LGTM.
|
@JonZeolla I am assuming you just added additional options that are now available. That being the case, +1 from me. |
|
Piling on with a +1, great job @JonZeolla |
iraghumitra
pushed a commit
to iraghumitra/incubator-metron
that referenced
this pull request
Nov 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Comments
Documentation fixes, pretty straightforward. Most notably documents all of the
start_parser_topology.shparams.Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:
For documentation related changes:
Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via
site-book/target/site/index.html:Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.