This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-248] Scala Infer API docs editorial pass #10307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronmarkham
changed the title
aaronmarkham
requested review from
cjolivier01,
szha and
thirdwing
as code owners
|
@aaronmarkham please rebase your branch from the master, this PR has a lot of edits to files that you probably didn't touch |
|
I think it expanded due to my rebase yesterday. The CI failure is scalastyle it seems... |
nswamy
approved these changes
Apr 5, 2018
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
* scala infer api docs update
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
* scala infer api docs update
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview
http://107.21.90.138/api/scala/docs/index.html#ml.dmlc.mxnet.infer.package
Edited every scala file in the Infer package that had any comments, and added comments to the SSD example.
Comments
There are quite a variety of scaladoc errors and warnings that need to be resolved, however, the output seems fine.
Scala API contributors: please run
make docsand check the output on the files you contributed or are maintaining, and resolve the issues!