-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
@zheng-da Could you add more descriptions (or change title) in order to make the PR readable? please try the case a3c, |
👍 for the descriptive title and PR description |
@pengzhao-intel what error do you see. |
@zheng-da Exactly. The exception is thrown in here. |
* Fix bugs in MKLDNN. * add more test cases. * Fix CopyFrom when it's the view of an NDArray. * add test. * check same shape correctly. * add unit test for CopyFrom. * Fix warning. * Add test sum. * fix sum. * Fix fallback. * Fix fallback of sum. * add tests. * Update mkldnn.cc
* Fix bugs in MKLDNN. * add more test cases. * Fix CopyFrom when it's the view of an NDArray. * add test. * check same shape correctly. * add unit test for CopyFrom. * Fix warning. * Add test sum. * fix sum. * Fix fallback. * Fix fallback of sum. * add tests. * Update mkldnn.cc
* Fix bugs in MKLDNN. * add more test cases. * Fix CopyFrom when it's the view of an NDArray. * add test. * check same shape correctly. * add unit test for CopyFrom. * Fix warning. * Add test sum. * fix sum. * Fix fallback. * Fix fallback of sum. * add tests. * Update mkldnn.cc
* Fix bugs in MKLDNN. * add more test cases. * Fix CopyFrom when it's the view of an NDArray. * add test. * check same shape correctly. * add unit test for CopyFrom. * Fix warning. * Add test sum. * fix sum. * Fix fallback. * Fix fallback of sum. * add tests. * Update mkldnn.cc
* Fix bugs in MKLDNN. * add more test cases. * Fix CopyFrom when it's the view of an NDArray. * add test. * check same shape correctly. * add unit test for CopyFrom. * Fix warning. * Add test sum. * fix sum. * Fix fallback. * Fix fallback of sum. * add tests. * Update mkldnn.cc
* Fix bugs in MKLDNN. * add more test cases. * Fix CopyFrom when it's the view of an NDArray. * add test. * check same shape correctly. * add unit test for CopyFrom. * Fix warning. * Add test sum. * fix sum. * Fix fallback. * Fix fallback of sum. * add tests. * Update mkldnn.cc
* Fix bugs in MKLDNN. * add more test cases. * Fix CopyFrom when it's the view of an NDArray. * add test. * check same shape correctly. * add unit test for CopyFrom. * Fix warning. * Add test sum. * fix sum. * Fix fallback. * Fix fallback of sum. * add tests. * Update mkldnn.cc
Description
This PR is to fix a few corner cases in NDArray:
I also adds more types of NDArrays to cover the cases described above.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.