This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-244] Fixed armv7 wheel (1.2.0 release) #11054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lebeg
changed the title
lebeg
force-pushed
the
armv7_fix_1.2.0
branch
3 times, most recently
from
fd66e93
to
c9e2d43
Compare
|
Is this ready to merge and tested on a physical raspberry? |
|
ping @lebeg . Is this ready ? Also has this been merged to the master ? |
|
@anirudh2290 No, this has not been merged to master: #11053 #11245 This change is complete as stated in the description. Unfortunately, I can confirm that though is builds well, MXNet does not work on some devices due to threading issues. Probably related to #8995 #11065 #10911 But I did not have time for now to test if these PR's are fixing the problem. |
anirudh2290
approved these changes
Jun 14, 2018
marcoabreu
pushed a commit
to marcoabreu/incubator-mxnet
that referenced
this pull request
Jun 14, 2018
* Fixed armv7 wheel * Fixed bash default value substitution * Fixed whitespace errors * Added unzip installation to crosscompile docker images * Removed deprecated apt lists removal * Moved common parts to scripts for docker builds * Disabled bundled OpenMP for cross compilation * Added make based build for armv7 as option * Renamed install_openblas.sh -> arm_openblas.sh * Removed makefile build for armv7 * Trigger CI * Link OpenBLAS statically for cross compilations
marcoabreu
pushed a commit
that referenced
this pull request
Jun 14, 2018
* Fixed armv7 wheel * Fixed bash default value substitution * Fixed whitespace errors * Added unzip installation to crosscompile docker images * Removed deprecated apt lists removal * Moved common parts to scripts for docker builds * Disabled bundled OpenMP for cross compilation * Added make based build for armv7 as option * Renamed install_openblas.sh -> arm_openblas.sh * Removed makefile build for armv7 * Trigger CI * Link OpenBLAS statically for cross compilations
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
Jun 15, 2018
* Fixed armv7 wheel * Fixed bash default value substitution * Fixed whitespace errors * Added unzip installation to crosscompile docker images * Removed deprecated apt lists removal * Moved common parts to scripts for docker builds * Disabled bundled OpenMP for cross compilation * Added make based build for armv7 as option * Renamed install_openblas.sh -> arm_openblas.sh * Removed makefile build for armv7 * Trigger CI * Link OpenBLAS statically for cross compilations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a path issue in the created by cross compilation python wheel for armv7 (RPi).
Checklist
Essentials
Changes
Comments
Release backport fix of #11053