This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
make slice operator 20x faster on GPU #11124
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reminisce
approved these changes
Jun 1, 2018
eric-haibin-lin
changed the title
[WIP] make slice operator 20x faster on GPU
make slice operator 20x faster on GPU
Jun 2, 2018
eric-haibin-lin
added a commit
to eric-haibin-lin/mxnet
that referenced
this pull request
Jun 11, 2018
* gpu slice kernel * remove unused line
anirudh2290
pushed a commit
that referenced
this pull request
Jun 11, 2018
* gpu slice kernel * remove unused line
7 tasks
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
* gpu slice kernel * remove unused line
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this pull request
Aug 29, 2018
* gpu slice kernel * remove unused line
No acceleration on the V100. |
@BiranLi How did you test this? I've seen 20x improvement on V100 using p3.2x instances. |
@safrooze Hi. What is the test environment on your side? What is the version of the mxnet used for comparison? What's your test code ? |
@safrooze I have tested in V100 between mxnet_0.12 and mxnet_1.3. |
@BiranLi i'm using this test code:
What did you use? Are you on slack? |
Yes, I was using the same test code. I get a similar result on both version mxnet(0.12 vs 1.3). |
Oh I didn't compare with mxnet 0.12. Maybe it was a regression between 0.12 and 1.2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current slice kernel is slow on GPU as each thread in the warp accesses different memory address in the output.
@reminisce @haojin2 @safrooze
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments
Time on K80