Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Disabled flaky test: test_mkldnn.test_activation #12378

Merged
merged 2 commits into from
Aug 29, 2018

Conversation

lebeg
Copy link
Contributor

@lebeg lebeg commented Aug 28, 2018

Description

Disable flaky test: test_mkldnn.test_activation. Tracked in #12377

@pengzhao-intel
Copy link
Contributor

Please refer the RCA in #12377 and wait a moment for the merge.
We need a better solution :)

@lebeg
Copy link
Contributor Author

lebeg commented Aug 29, 2018

@pengzhao-intel Sure) But it's better to disable a flaky test first and so that PR's from others are not blocked and then add it again with a proper fix.

@lebeg
Copy link
Contributor Author

lebeg commented Aug 29, 2018

@pengzhao-intel
Copy link
Contributor

@lebeg please see my comments on #12377.
Could you try to change eps number and run these cases again?

@lebeg
Copy link
Contributor Author

lebeg commented Aug 29, 2018

@pengzhao-intel my intent with this PR is disabling the test, not to make it pass. As far as I have understood from #12377 @luobao-intel will submit a fix for the test soon and he could enable the test again in the same PR.

@lebeg lebeg force-pushed the disable_test_mkldnn.test_activation branch from ee4b701 to ca2a9cb Compare August 29, 2018 10:29
@lebeg lebeg requested a review from marcoabreu as a code owner August 29, 2018 10:29
@lebeg
Copy link
Contributor Author

lebeg commented Aug 29, 2018

Would that be alright with you @pengzhao-intel @luobao-intel?

@pengzhao-intel
Copy link
Contributor

It's fine for us. Please go ahead.

@marcoabreu marcoabreu merged commit 65c374d into apache:master Aug 29, 2018
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Sep 19, 2018
* Disabled flaky test: test_mkldnn.test_activation

* Revert accidental change
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants