Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Update 3rdparty/mkldnn remote URL and pin to v1.3 (#17972) #18033

Merged
merged 3 commits into from Apr 15, 2020

Conversation

TaoLv
Copy link
Member

@TaoLv TaoLv commented Apr 12, 2020

  • update onednn remote url

  • checkout onednn v1.3 release

  • fix format test

  • make test
    Conflicts:
    .gitmodules
    3rdparty/mkldnn
    tests/cpp/operator/mkldnn_test.cc

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

* update onednn remote url

* checkout onednn v1.3 release

* fix format test

* make test
Conflicts:
	.gitmodules
	3rdparty/mkldnn
	tests/cpp/operator/mkldnn_test.cc
@mxnet-bot
Copy link

Hey @TaoLv , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, website, windows-gpu, windows-cpu, unix-cpu, edge, centos-cpu, centos-gpu, clang, sanity, unix-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@TaoLv
Copy link
Member Author

TaoLv commented Apr 12, 2020

cc @ciyongch

@TaoLv TaoLv added the v1.x Targeting v1.x branch label Apr 12, 2020
@TaoLv
Copy link
Member Author

TaoLv commented Apr 15, 2020

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@ciyongch
Copy link
Contributor

Adding this to v1.7.0 roadmap #16864

@TaoLv
Copy link
Member Author

TaoLv commented Apr 15, 2020

@leezu I borrowed the cmake upgrade code from #17645 as the new DNNL library needs higher version of cmake than the one in v1.x CI. Please let me know if you have any concern. Thanks.

Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pengzhao-intel pengzhao-intel added this to In progress in CPU Performance and Quantization via automation Apr 15, 2020
@pengzhao-intel pengzhao-intel merged commit 2cf7219 into apache:v1.x Apr 15, 2020
CPU Performance and Quantization automation moved this from In progress to Done Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
MKLDNN v1.x Targeting v1.x branch
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants