Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix oneDNN feature name in MxNET #20070

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Conversation

bartekkuncer
Copy link
Contributor

@bartekkuncer bartekkuncer commented Mar 22, 2021

Description

Fixes #20069.

Checklist

Changes

  • Changed MxNET feature name from MKLDNN to ONEDNN

@mxnet-bot
Copy link

Hey @bartekkuncer , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, unix-cpu, windows-cpu, centos-cpu, clang, centos-gpu, unix-gpu, edge, windows-gpu, website, sanity]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Mar 22, 2021
bartekkuncer referenced this pull request in horovod/horovod Mar 22, 2021
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
@EnricoMi
Copy link

@bartekkuncer looks good, thanks!

There are still plenty of MKLDNN occurrences in docs and sources. This renaming is really touching everything.

@bartekkuncer
Copy link
Contributor Author

There are still plenty of MKLDNN occurrences in docs and sources. This renaming is really touching everything.

@EnricoMi That is true, therefore as of now we wanted to stick to changing only major build and runtime flag names and as soon as oneDNN will update its API from dnnl we will try to unify all the names on master to oneDNN to avoid further confusion.

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 22, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 22, 2021
@bartekkuncer
Copy link
Contributor Author

@leezu @szha Please help with the merge :)

@szha szha merged commit 626f933 into apache:master Mar 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OneDNN feature still being called MKLDNN
5 participants