Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.9.x] Add copyright detection and removal in license checker #20498

Merged
merged 3 commits into from Aug 10, 2021
Merged

[v1.9.x] Add copyright detection and removal in license checker #20498

merged 3 commits into from Aug 10, 2021

Conversation

szha
Copy link
Member

@szha szha commented Aug 7, 2021

Description

Add copyright detection and removal in license checker

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)

Changes

  • Add copyright detection and removal in license checker

@mxnet-bot
Copy link

Hey @szha , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [edge, windows-gpu, clang, sanity, miscellaneous, centos-cpu, windows-cpu, centos-gpu, unix-cpu, website, unix-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 7, 2021
@szha
add old copyright checker
4c1ecfa 
Signed-off-by: Sheng Zha <zhasheng@amazon.com>
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 7, 2021
@szha
add removal function for old copyright
a78b8d5 
Signed-off-by: Sheng Zha <zhasheng@amazon.com>
@szha
fix remaining files
67b04fb 
Signed-off-by: Sheng Zha <zhasheng@amazon.com>
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 7, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 9, 2021
josephevans
josephevans approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@josephevans josephevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, LGTM!

@szha szha merged commit 13df0d7 into apache:v1.9.x Aug 10, 2021
@szha szha deleted the no_copyright branch August 10, 2021 00:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephevans josephevans josephevans approved these changes

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@anirudh2290 anirudh2290 Awaiting requested review from anirudh2290 anirudh2290 is a code owner

@nswamy nswamy Awaiting requested review from nswamy nswamy is a code owner

@thirdwing thirdwing Awaiting requested review from thirdwing thirdwing is a code owner

@yzhliu yzhliu Awaiting requested review from yzhliu yzhliu is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@szha @mxnet-bot @josephevans @mseth10