MYFACES-4390: HtmlInputFile multiple support

[melloware]

I feel like an alien in this code base!

I didn't see any existing tests to update so i wasn't even sure where to begin to add a test for this?

[melloware]

Also there were some warnings from IntelliJ about some evaluations ALWAYS being true etc but I did not fix any of them only touched the bare minimum to add this feature.

[melloware]

Also unsure as its mentioned it should render multiple="multiple" but right now I think it would render multiple="true". I still think multiple="true" is OK.

[tandraschko]

why not
writer.writeAttribute(HTML.MULTIPLE_ATTR, "multiple", null); then?

[melloware]

OK I updated it. to write out "multiple" but what threw me off is the lines above it were this...

if (inputFile.isDisabled())
{
     writer.writeAttribute(HTML.DISABLED_ATTR, Boolean.TRUE, null);
}

But in PrimeFaces code we do this...

 writer.writeAttribute("disabled", "disabled", null);

[GedMarc]

yeah disabled=true doesn't work across all browsers, has to be just "disabled" or "disabled=disabled",

Multiple is the same, cant be multiple=true, must be multiple=multiple, or just "multiple"

[GedMarc]

ref here https://stackoverflow.com/questions/6961526/what-is-the-correct-value-for-the-disabled-attribute

Don't use attributes=true for these at all, ever

[melloware]

Thanks @GedMarc. So @tandraschko so then the Disabled attribute here is incorrect then.

[tandraschko]

@melloware would you please add a jira issue and provide a PR? would be great!

[melloware]

Yep will do!