Fix not working MTU exchange on newer versions of mac #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ccollins476ad I know this is dirty hack, but we had no better idea to fix this. This way image upload over ble at least works (unless the boards MTU turns out to be less than 185). |
sjanc
reviewed
Dec 19, 2022
newtmgr/bll/bll_common.go
Outdated
| // On some versions of mac (e.g. monterey) workaround with | ||
| // looping three times seems to not work anymore. If after | ||
| // performing three loops MTU is still <=23 than hardcode it to 185. | ||
| if mtu <= bledefs.BLE_ATT_MTU_DFLT { |
There was a problem hiding this comment.
it is perfectly fine to end with default MTU after MTU exchange, we should consider overriding MTu only if it is invalid ( less than default)
m-gorecki
force-pushed
the
mac-fix
branch
2 times, most recently
from
ae6571b
to
4055cb4
Compare
It seems like on newer versions of mac (e.g. Monterey) fix with looping three times to get right MTU doesn't work. Also for some strange reason default TxMTU is set to 17 instead of 23. Now user can set MTU from the command line (-m <MTU value>). If MTU is not set in the command line and after performing three loops MTU is still <23 we hardcode it to 185.
sjanc
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like on newer versions of mac (e.g. Monterey) fix with looping three times to get right MTU doesn't work. Also for some strange reason default TxMTU is set to 17 instead of 23. Now user can set MTU from the command line (-m ). If MTU is not set in the command line and after performing three loops MTU is still <23 we hardcode it to 185.