[linux] initial port and osal additions. #4

turon · 2018-01-18T19:22:13Z

Created linux port of os_task, os_sem, os_mutex, os_callout, os_eventq, etc.
Added unit tests for osal.
Mods to support pointer alignment on 64-bit architectures.
Fixes to ble_hci_sock to support linux port
Fallback to BLE 4.2 or 4.0 controllers when 5.0 features not available.

Tested advertising, scan response, connections and GATT database operations.

- Created linux port of os_task, os_sem, os_mutex, os_callout, etc. - Added unit tests for osal. - Mods to support pointer alignment on 64-bit architectures. - Fixes to ble_hci_sock to support linux port - Fallback to BLE 4.2 or 4.0 controllers when 5.0 features not available. - Added Linux instructions to README.

turon · 2018-01-19T19:16:07Z

porting/common/src/sysinit/sysinit.c

@@ -34,7 +36,8 @@ sysinit_dflt_panic_cb(const char *file, int line, const char *func,
    }
 #endif

-    __assert_func(file, line, func, expr);
+    __assert_fail(msg, file, line, func);
+    //__assert_func(file, line, func, expr);


This is a known conflict between FreeRTOS and Linux that needs to be resolved before merging.

sterlinghughes · 2018-03-22T16:22:22Z

@andrzej-kaczmarek are we good to merge this?

andrzej-kaczmarek · 2018-03-27T12:29:23Z

@sterlinghughes I need to update porting layer and push it to latest official master - I'm on it. Then this can be put on top, perhaps after some changes.

sjanc

Hi,

some comments on what needs to be updated before this could go in:

in general license stuff needs to be fixed
code should be C
there seems to be some not needed SDK code that should be removed
this is a bit less important but code should follow Mynewt coding style (also for comments /**/ instead of C++//)

I put some comments inline in places I spotted, but if I miss anything similar it should also be fixed.

sjanc · 2018-02-09T08:22:42Z

porting/linux/Makefile.common

+#
+# Licensees are granted free, non-transferable use of the information. NO
+# WARRANTY of ANY KIND is provided. This heading must NOT be removed from
+# the file.


Needs to be checked if this license is apache approved.

sjanc · 2018-02-09T08:23:07Z

porting/linux/config/sdk_config.h

@@ -0,0 +1,698 @@
+


miising license

is this needed anyway for host?

sjanc · 2018-02-09T08:26:03Z

porting/linux/os/os_atomic.c

+void os_atomic_end()
+{
+    pthread_mutex_unlock(&s_mutex);
+    pthread_cond_signal(&s_cond);


why this conditional is needed? there seems to be no pthread_cond_wait() called anywhere for s_cond

sjanc · 2018-02-09T08:28:54Z

porting/linux/os/os_mutex.c

+os_error_t
+os_mutex_release(struct os_mutex *mu)
+{
+    if (!mu) return OS_INVALID_PARM;


coding style

sjanc · 2018-02-09T08:29:03Z

porting/linux/os/os_mutex.c

+os_error_t
+os_mutex_pend(struct os_mutex *mu, uint32_t timeout)
+{
+    if (!mu) return OS_INVALID_PARM;


coding style

sjanc · 2018-02-09T08:29:28Z

porting/linux/os/os_mutex.c

+
+    assert(&mu->lock);
+
+    struct timespec wait;


variables should be defined at beginning of function

sjanc · 2018-02-09T08:30:08Z

porting/linux/os/os_sem.c

+os_error_t
+os_sem_init(struct os_sem *sem, uint16_t tokens)
+{
+    if (!sem)


sjanc · 2018-02-09T08:30:29Z

porting/linux/os/os_sem.h

@@ -0,0 +1,26 @@
+#ifndef _OS_SEM_H_


sjanc · 2018-04-04T09:36:16Z

porting/linux/os/os_atomic.c

+#include <pthread.h>
+
+pthread_mutex_t s_mutex = PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP;
+pthread_cond_t s_cond = PTHREAD_COND_INITIALIZER;


should be static?

turon · 2018-05-12T21:13:12Z

Usurped by #90.

It is possible that scheduler already fired and aux data is NULL so we should unref it only if scheduler item was removed. ble_ll_scan_aux_data_unref (aux_data=<optimized out>) at repos/apache-mynewt-nimble/nimble/controller/src/ble_ll_scan.c:1079 1079 BLE_LL_ASSERT(aux_data); (gdb) bt #0 ble_ll_scan_aux_data_unref (aux_data=<optimized out>) at repos/apache-mynewt-nimble/nimble/controller/src/ble_ll_scan.c:1079 apache#1 0x0001f732 in ble_ll_scan_rx_pkt_in_on_aux (pdu_type=<optimized out>, om=0x2000d6f8 <os_msys_1_data>, hdr=0x2000d710 <os_msys_1_data+24>, addrd=addrd@entry=0x20004ecc <g_ble_ll_stack+404>) at repos/apache-mynewt-nimble/nimble/controller/src/ble_ll_scan.c:3156 apache#2 0x0002010e in ble_ll_scan_rx_pkt_in (ptype=ptype@entry=7 '\a', om=om@entry=0x2000d6f8 <os_msys_1_data>, hdr=hdr@entry=0x2000d710 <os_msys_1_data+24>) at repos/apache-mynewt-nimble/nimble/controller/src/ble_ll_scan.c:3198 apache#3 0x0001299e in ble_ll_rx_pkt_in () at repos/apache-mynewt-nimble/nimble/controller/src/ble_ll.c:837 apache#4 0x000129de in ble_ll_event_rx_pkt (ev=<optimized out>) at repos/apache-mynewt-nimble/nimble/controller/src/ble_ll.c:1164 apache#5 0x00012830 in ble_npl_event_run (ev=<optimized out>) at repos/apache-mynewt-nimble/porting/npl/mynewt/include/nimble/nimble_npl_os.h:116 apache#6 ble_ll_task (arg=<optimized out>) at repos/apache-mynewt-nimble/nimble/controller/src/ble_ll.c:1214 apache#7 0x00038e9c in nrf52_clock_hfxo_release () at repos/apache-mynewt-core/hw/mcu/nordic/nrf52xxx/include/mcu/cortex_m4.h:37 apache#8 0x00000000 in ?? ()

It is possible that scheduler already fired and aux data is NULL so we should unref it only if scheduler item was removed. ble_ll_scan_aux_data_unref (aux_data=<optimized out>) at repos/apache-mynewt-nimble/nimble/controller/src/ble_ll_scan.c:1079 1079 BLE_LL_ASSERT(aux_data); (gdb) bt #0 ble_ll_scan_aux_data_unref (aux_data=<optimized out>) at repos/apache-mynewt-nimble/nimble/controller/src/ble_ll_scan.c:1079 #1 0x0001f732 in ble_ll_scan_rx_pkt_in_on_aux (pdu_type=<optimized out>, om=0x2000d6f8 <os_msys_1_data>, hdr=0x2000d710 <os_msys_1_data+24>, addrd=addrd@entry=0x20004ecc <g_ble_ll_stack+404>) at repos/apache-mynewt-nimble/nimble/controller/src/ble_ll_scan.c:3156 #2 0x0002010e in ble_ll_scan_rx_pkt_in (ptype=ptype@entry=7 '\a', om=om@entry=0x2000d6f8 <os_msys_1_data>, hdr=hdr@entry=0x2000d710 <os_msys_1_data+24>) at repos/apache-mynewt-nimble/nimble/controller/src/ble_ll_scan.c:3198 #3 0x0001299e in ble_ll_rx_pkt_in () at repos/apache-mynewt-nimble/nimble/controller/src/ble_ll.c:837 #4 0x000129de in ble_ll_event_rx_pkt (ev=<optimized out>) at repos/apache-mynewt-nimble/nimble/controller/src/ble_ll.c:1164 #5 0x00012830 in ble_npl_event_run (ev=<optimized out>) at repos/apache-mynewt-nimble/porting/npl/mynewt/include/nimble/nimble_npl_os.h:116 #6 ble_ll_task (arg=<optimized out>) at repos/apache-mynewt-nimble/nimble/controller/src/ble_ll.c:1214 #7 0x00038e9c in nrf52_clock_hfxo_release () at repos/apache-mynewt-core/hw/mcu/nordic/nrf52xxx/include/mcu/cortex_m4.h:37 #8 0x00000000 in ?? ()

turon force-pushed the linux-port branch from 0267ba1 to c3969ef Compare January 18, 2018 21:27

turon commented Jan 19, 2018

View reviewed changes

Fix linux / freertos build conflict.

2a22b29

sterlinghughes requested a review from andrzej-kaczmarek March 22, 2018 16:22

sjanc requested changes Apr 4, 2018

View reviewed changes

This was referenced Apr 16, 2018

ble_ll_scan.c calls ble_ll_scan_init twice, which corrupts g_os_mempool_list #46

Closed

Extended Advertisement Issues #44

Closed

turon closed this May 12, 2018

sjanc mentioned this pull request Feb 4, 2020

nimble/ll: Fix assert in extended scanner #748

Merged

kasjer pushed a commit to kasjer/mynewt-nimble that referenced this pull request Mar 9, 2022

fake dual: yet another apache#4

1c62e6b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[linux] initial port and osal additions. #4

[linux] initial port and osal additions. #4

turon commented Jan 18, 2018

turon Jan 19, 2018

sterlinghughes commented Mar 22, 2018

andrzej-kaczmarek commented Mar 27, 2018

sjanc left a comment

sjanc Feb 9, 2018

sjanc Feb 9, 2018

sjanc Apr 4, 2018

sjanc Feb 9, 2018

sjanc Feb 9, 2018

sjanc Feb 9, 2018

sjanc Feb 9, 2018

sjanc Feb 9, 2018

sjanc Feb 9, 2018

sjanc Apr 4, 2018

turon commented May 12, 2018

[linux] initial port and osal additions. #4

[linux] initial port and osal additions. #4

Conversation

turon commented Jan 18, 2018

Choose a reason for hiding this comment

sterlinghughes commented Mar 22, 2018

andrzej-kaczmarek commented Mar 27, 2018

sjanc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

turon commented May 12, 2018