Polishing Gradle HTML UI #1279
Polishing Gradle HTML UI #1279
Conversation
|
"needs API for synchronous build execution" what doe that mean? |
| @@ -250,6 +251,9 @@ private static void invokeProjectAction(final Project project, final ActionMappi | |||
| prj.reloadProject(true, maxQualily, reloadArgs); | |||
| } | |||
| project.getLookup().lookup(AfterBuildActionHook.class).afterAction(action, outerCtx, task.result(), out1); | |||
| for (TaskListener l : context.lookupAll(TaskListener.class)) { | |||
| l.taskFinished(t); | |||
There was a problem hiding this comment.
This is the extension created for synchronous execution of the BUILD and RUN actions in the test, @lkishalmi.
There was a problem hiding this comment.
Well, I would not leak the task out of this context. As far as I see registering an AfterBuildActionHook could do the same as this task listener magic.
There was a problem hiding this comment.
Rewritten to AfterBuildActionHook in cee89d4 - but it still needs a change in ActionProviderImpl. The previous code only searched project.getLookup()...
| waiter.countDown(); | ||
| }; | ||
| actions.invokeAction(cmd, Lookups.fixed(prj, notifier)); | ||
| waiter.await(); |
There was a problem hiding this comment.
The invokeCommand has to wait till the cmd action is finished, @lkishalmi.
| @@ -250,6 +251,9 @@ private static void invokeProjectAction(final Project project, final ActionMappi | |||
| prj.reloadProject(true, maxQualily, reloadArgs); | |||
| } | |||
| project.getLookup().lookup(AfterBuildActionHook.class).afterAction(action, outerCtx, task.result(), out1); | |||
| for (TaskListener l : context.lookupAll(TaskListener.class)) { | |||
| l.taskFinished(t); | |||
There was a problem hiding this comment.
Well, I would not leak the task out of this context. As far as I see registering an AfterBuildActionHook could do the same as this task listener magic.
| for (TaskListener l : context.lookupAll(TaskListener.class)) { | ||
| l.taskFinished(t); | ||
| for (AfterBuildActionHook l : context.lookupAll(AfterBuildActionHook.class)) { | ||
| l.afterAction(action, outerCtx, task.result(), out1); | ||
| } |
There was a problem hiding this comment.
That's actually a nice enhancement. Thank you for that!
The HTML UI wizard needs some improvements to be considered stable.
appsubproject - let's comment it out for forthcoming releaseCC @lkishalmi , @neilcsmith-net