Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-2722] Upload button text and def. window size #1493

Merged
merged 2 commits into from
Sep 11, 2019

Conversation

riksoft
Copy link
Contributor

@riksoft riksoft commented Sep 11, 2019

https://issues.apache.org/jira/browse/NETBEANS-2722

The text "Take over local changes" it's unclear. Changed into "Upload local changes"

The default diff window size is too small. Changed to 1024x768 (Just to be conservative... but it's still too small for me).
The diff window size should be improved implementing the persistance of the resized window size to let any user set whatever he wants.

https://issues.apache.org/jira/browse/NETBEANS-2722

The text "Take over local changes" it's unclear. Changed into "Upload local changes"

The default diff window size is too small. Changed to 1024x768 (Just to be conservative... but it's still too small for me).
The diff window size should be improved implementing the persistance of the resized window size to let any user set whatever he wants.
@geertjanw
Copy link
Member

Great job!

@geertjanw geertjanw changed the title Upload button text and def. window size [NETBEANS-2722] Upload button text and def. window size Sep 11, 2019
@junichi11
Copy link
Member

junichi11 commented Sep 11, 2019

Please apply this patch to your patch-1 branch if needed:

git pull https://github.com/junichi11/netbeans netbeans-2722

or

curl -L https://github.com/junichi11/netbeans/commit/d6cf197097b82c9a6848088bef59b809472a7920.patch | git am

netbeans-2722

@junichi11
Copy link
Member

junichi11 commented Sep 11, 2019

@riksoft
Please read this: https://netbeans.apache.org/participate/submit-pr.html
As Geertjan changed the title, we have to add issue number to the commit message and the PR title.
Please do that from next time :)

@riksoft
Copy link
Contributor Author

riksoft commented Sep 11, 2019

@junichi11
OK. Actually Geertjan told me to do that but using the word "description" I didn't realize I have to put the bug code in the title. Next time! :-)

@junichi11
Copy link
Member

@riksoft If you apply my patch(keep the last diff window size) to your patch-1 branch, please push it.

$ cd netbeans
$ git pull https://github.com/junichi11/netbeans netbeans-2722
$ git push origin patch-1

Otherwise, please let me know.

@riksoft
Copy link
Contributor Author

riksoft commented Sep 11, 2019

@junichi11
I don't have a local evironment for Java/Netbeans development (I did the editing directly on github, not locally), so I can't apply your pach, test, or push back. I could set a VM for such purpose but it takes time and I can't do it now.

@junichi11
Copy link
Member

@riksoft please add me(junichi11) to your repo as a collaborators if possible. I can add the commit.

@junichi11
Copy link
Member

BTW, Maybe, you should have a local repository because you can't pull new changes from the remote repository and can't test changes.

@riksoft
Copy link
Contributor Author

riksoft commented Sep 11, 2019

@junichi11
The problem is that I'm not a java developer, that's why I've never bothered to install Netbeans source code locally.
BTW you've been added to my repo.

@junichi11
Copy link
Member

The problem is that I'm not a java developer, that's why I've never bother to install Netbeans source code locally.

I see. Personally, I don't think that it is good way...

BTW you've been added to my repo.

Thanks! I'll push my change.

Copy link
Member

@junichi11 junichi11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need the review from @tmysik

Copy link
Member

@tmysik tmysik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not try it but looks good to me.

@junichi11
Copy link
Member

junichi11 commented Sep 11, 2019

@tmysik Thank you! Will merge if Travis CI passes.

@junichi11 junichi11 added the PHP [ci] enable extra PHP tests (php/php.editor) label Sep 11, 2019
@junichi11 junichi11 added this to the 11.2 milestone Sep 11, 2019
@junichi11 junichi11 merged commit 411fc7b into apache:master Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants