-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NETBEANS-2722] Upload button text and def. window size #1493
Conversation
https://issues.apache.org/jira/browse/NETBEANS-2722 The text "Take over local changes" it's unclear. Changed into "Upload local changes" The default diff window size is too small. Changed to 1024x768 (Just to be conservative... but it's still too small for me). The diff window size should be improved implementing the persistance of the resized window size to let any user set whatever he wants.
Great job! |
@riksoft |
@junichi11 |
@riksoft If you apply my patch(keep the last diff window size) to your
Otherwise, please let me know. |
@junichi11 |
@riksoft please add me(junichi11) to your repo as a collaborators if possible. I can add the commit. |
BTW, Maybe, you should have a local repository because you can't pull new changes from the remote repository and can't test changes. |
@junichi11 |
I see. Personally, I don't think that it is good way...
Thanks! I'll push my change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need the review from @tmysik
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not try it but looks good to me.
@tmysik Thank you! Will merge if Travis CI passes. |
https://issues.apache.org/jira/browse/NETBEANS-2722
The text "Take over local changes" it's unclear. Changed into "Upload local changes"
The default diff window size is too small. Changed to 1024x768 (Just to be conservative... but it's still too small for me).
The diff window size should be improved implementing the persistance of the resized window size to let any user set whatever he wants.