[NETBEANS-5661] - Added regular expression window and hint

[mishrasandeep]

https://issues.apache.org/jira/browse/NETBEANS-5661 Adding a feature for testing the valid values for a Regular Expression in the IDE itself.

• Added the window to the Menu. Can be accessed from Menu/Window without context.
• Can be reference with shortcut Ctrl + 8 (not being used for any other action)
• Added strict check option to disable checking for substring values matching the regular expression.

Modified "Malformed Regexp" (shows invalid regular expression description) Hint to severity error instead of warning and scan for value of the identifiers.

[junichi11]

I reviewed only code style.

[jkovalsky]

I have provided some minor comments for your code but in general it looks good to me. Before approving this PR I would recommend though to:

• rename the UI widgets to meaningful names (not jLabel1 etc.) as @junichi11 already mentioned above
• listen to keystrokes also in the jTextArea1 ;) so that if one modifies the regular expression it immediately reevaluates the example
• take a look at failed unit tests to avoid unwanted regressions

[junichi11]

@mishrasandeep
Thank you for your contribution!
Could you please squash as one commit with a proper commit message after you fix all? (We don't use the squash and merge button.)

[singh-akhilesh]

LGTM

[Akshay-Gupta-19]

Looks correct to me.

[jkovalsky]

Thanks for addressing my previous comments. I have provided some more findings. Otherwise I am fine with the work and approve it.

[mishrasandeep]

@mishrasandeep
Thank you for your contribution!
Could you please squash as one commit with a proper commit message after you fix all? (We don't use the squash and merge button.)

@junichi11
Have addressed all the comments and squashed the commits. Any other inputs from your end?

[junichi11]

Could you please check to format (ranges of your changes) again? (I didn't take a look at all files.)

[junichi11]

Maybe, We should also update this file: https://github.com/apache/netbeans/blob/master/java/java.hints/licenseinfo.xml

@matthiasblaesing Aren't the license of png files checked via CI(RAT)?

[mishrasandeep]

Maybe, We should also update this file: https://github.com/apache/netbeans/blob/master/java/java.hints/licenseinfo.xml

@matthiasblaesing Aren't the license of png files checked via CI(RAT)?

@junichi11 should I go ahead and update the file?

[junichi11]

should I go ahead and update the file?

@mishrasandeep Yes. Let's update it for your new png files.

[mishrasandeep]

should I go ahead and update the file?

@mishrasandeep Yes. Let's update it for your new png files.

@junichi11 have updated the license file

[sdedic]

Is it possible to include this in 12.5 ?

[junichi11]

@mishrasandeep Thank you for fixing it. I reviewed only code style.
Could you please squash again?

[junichi11]

@sdedic @jkovalsky @Akshay-Gupta-Oracle @singh-akhilesh
If it's OK for you please feel free to merge this after commits are squashed. (Is the Travis error OK?)

[sdedic]

Is the Travis error OK?

Should be - it's a timeout (happens sometimes).

[ebarboni]

Should be - it's a timeout (happens sometimes).

Too often :D, Let's merge this