Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix being shown incorrect documentation #4494 #5701

Merged
merged 1 commit into from
Mar 26, 2023

Conversation

junichi11
Copy link
Member

Example

<?php

/**
 * function gh4494.
 *
 * @return void
 */
function gh4494(): void {
    
}

/**
 * function gh4494_aa().
 *
 * @return void
 */
function gh4494_aa(): void {
    
}

/**
 * function gh4494_aa_bb().
 *
 * @return void
 */
function gh4494_aa_bbb(): void {
    
}

/**
 * function gh4494_aa_bb_cc().
 *
 * @return void
 */
function gh4494_aa_bb_cc(): void {
    
}

gh4494_aa_bb_cc();

Before:

nb-php-4494-before

After:

nb-php-4494-after

@junichi11 junichi11 added PHP [ci] enable extra PHP tests (php/php.editor) CSL [ci] enable web job labels Mar 22, 2023
@junichi11 junichi11 added this to the NB18 milestone Mar 22, 2023
@junichi11 junichi11 requested a review from tmysik March 24, 2023 22:05
@junichi11
Copy link
Member Author

@tmysik Could you please have a look at this? If there is no problem, let's merge it :) Thank you!

@tmysik
Copy link
Member

tmysik commented Mar 25, 2023

@junichi11 @sdedic

Don't we need to increase version of the csl.api module? Or in tests, this is not needed? 🤔

If not, feel free to merge.

Thanks.

@junichi11
Copy link
Member Author

junichi11 commented Mar 25, 2023

Will increase it later :) Thank you!

- apache#4494
- Add a new test method for checking documentation when a `QueryType` is `DOCUMENTATION` to `CslTestBase`
- If `QueryType` is `DOCUMENTATION`, get a whole identifier as a prefix
- Add unit tests
- Increase spec versions
@junichi11 junichi11 force-pushed the php-gh-4494-show-documentation branch from 6b8d6ea to f25bbd1 Compare March 25, 2023 06:16
@junichi11
Copy link
Member Author

Increased spec versions.

@tmysik
Copy link
Member

tmysik commented Mar 25, 2023

The failing check can hardly be related, right?

@tmysik
Copy link
Member

tmysik commented Mar 25, 2023

I cannot easily check it, I am on my phone only 😅

@junichi11
Copy link
Member Author

I'll re-run it :)

@junichi11
Copy link
Member Author

All checks are green :)

@tmysik
Copy link
Member

tmysik commented Mar 26, 2023

Great! Merging then...

@tmysik tmysik merged commit bceb81b into apache:master Mar 26, 2023
@junichi11 junichi11 deleted the php-gh-4494-show-documentation branch March 26, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSL [ci] enable web job PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP: Show documentation (ctrl+shift+space) displays incorrect documentation
3 participants