Added support for Kotlin LSP Server.

[jkost]

Fixed Issue NETBEANS-6098; added initial support for the Kotlin programming language using the LSP protocol: syntax highlighting, code completion, braces matching etc.

---

^Add meaningful description above

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

• are all your own work, and you have the right to contribute them.
• are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

[jlahoda]

Makes sense to me.

[matthiasblaesing]

I set the "do not merge" flag, as the author information is invalid for this: jkost <jkost@users.noreply.github.com>. This looks like the crap github produces when using its utilities. Please check either your local history with a good git tool (git log) or check this:

https://patch-diff.githubusercontent.com/raw/apache/netbeans/pull/6384.patch

You can see, that the author information neither holds your real name, nor a valid e-mail address. At the chance, that I sound like a broken record: I strongly advise not to use the github to do anything, that is more complex, than a simple merge. If you need to rebase or squash, do that locally, I have yet to see a sane commit from githubs systems.

[vieiro]

Some comments below. It's not clear to me how the binary is downloaded. We may want to upload it to the OSWUL server. Let me know if you need help on this.

[matthiasblaesing]

Some comments below. It's not clear to me how the binary is downloaded. We may want to upload it to the OSWUL server. Let me know if you need help on this.

This is not necessary and run contrary to the intention of the extension. The "external" file is used at installation time (aka runtime) to fetch the referenced binary. If I remember correctly, this mechanism was introduced to make it possible to create NBMs bundling libraries, not compatbile with GPLv2/CDDL and distribute these with the IDE/derived products. That also answers the question about the external file. This file has (a) not enough to content to be copyrightable by itself (IANAL!) and (b) I assume @jkost created the file, so he is author and in this case I don't see why it should not be ALv2. It references non-ASF material, but that is also true for the OpenJFX integration.

[vieiro]

Some comments below. It's not clear to me how the binary is downloaded. We may want to upload it to the OSWUL server. Let me know if you need help on this.

This is not necessary and run contrary to the intention of the extension. The "external" file is used at installation time (aka runtime) to fetch the referenced binary. If I remember correctly, this mechanism was introduced to make it possible to create NBMs bundling libraries, not compatbile with GPLv2/CDDL and distribute these with the IDE/derived products. That also answers the question about the external file. This file has (a) not enough to content to be copyrightable by itself (IANAL!) and (b) I assume @jkost created the file, so he is author and in this case I don't see why it should not be ALv2. It references non-ASF material, but that is also true for the OpenJFX integration.

Ah, pretty cool then. We're good!

[neilcsmith-net]

I set the "do not merge" flag, as the author information is invalid for this: ...

The other invalid author information is that, while @jkost is on the PMC, the GitHub account is not linked to the ASF membership. Which also links it to validation of identity, ICLA, etc. Please fix this before the PR is merged.

We may want to upload it to the OSWUL server. Let me know if you need help on this.

I realise this is not relevant to this PR. But as a general comment, my understanding was that OSUOSL was a legacy, transitional mechanism. Ideally we'd be, and have been, moving things away from it, not adding more to it.

[hantsy]

There is a discussion in IntelliJ Kotlin for NetBeans to donate it to Apache NetBeans project, JetBrains/kotlin-netbeans#137

But no further progress found there.

[jkost]

This is an old request. I have spent quite some time to try to build JetBrains donation, but the kotlin files produce 100s of errors. I asked in the mailing list for help, nobody volunteered. I have updated confluence <https://cwiki.apache.org/confluence/display/NETBEANS/Kotlin+support> accordingly. I think the LSP is the way to go.This is what I 'm currently working on.

…

On Wed, Sep 13, 2023 at 10:08 AM Hantsy Bai ***@***.***> wrote: There is a discussion in IntelliJ Kotlin for NetBeans to donate it to Apache NetBeans project, JetBrains/kotlin-netbeans#137 <JetBrains/kotlin-netbeans#137> But no further progress found there. — Reply to this email directly, view it on GitHub <#6384 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADJUYF5W6ZSI2N764RMVMDX2FSYRANCNFSM6AAAAAA4DRL7NE> . You are receiving this because you were mentioned.Message ID: ***@***.***>