UpdateDependencyHint should work on plugins with default maven group id #6493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
Maven
mbien
commented
Sep 25, 2023
Comment on lines
-19
to
-23
| javac.source=1.8 | ||
| javac.source=11 | ||
| javac.target=11 | ||
| #javac.compilerargs=-Xlint -Xlint:-serial | ||
|
|
||
| test.config.stableBTD.includes=**/*Test.class | ||
| requires.nb.javac=true |
There was a problem hiding this comment.
the build puts nb-javac into the boot classpath which makes it incompatible with the release option (which is set by the ant task automatically). Luckily this module doesn't need nb-javac.
java/maven.hints/src/org/netbeans/modules/maven/hints/pom/UpdateDependencyHint.java
Outdated
Show resolved
Hide resolved
- default plugins can omit the group ID, the hint should still check their versions - made hint aware of the reporting plugin section (thanks Matthias Bläsing) - moved module to JDK 11 since it already has JDK 11 dependencies
mbien
force-pushed
the
dep-hint-default-maven-plugin
branch
from
51f90f7
to
028e3fb
Compare
matthiasblaesing
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example: