Report all occurences of a vulnerability. #6972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdedic
added
LSP
MartinBalin
approved these changes
Jan 19, 2024
|
As @MartinBalin is unavailable but has approved, I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ADM vulnerability support reports were not complete. For a given vulnerable artifact (group:artifact:version), SOME location where it was used (or recursively included by other artifact) was reported. All paths - direct dependencies that introduce the vulnerable piece (although recursively) should be reported IMHO.
This PR changes the processing, so it reports all occurrences of a vulnerability.
During testing, I discovered that Maven
DependencyResultdoes not react properly to unsaved document changes. It is fixable, but maven Embedder module's friend API should be extended, which I'd like to defer to NB22. Tracked as #6973.A related patch in the LSP TextDocumentServiceImpl is related to #6971, which I hope will be fixed in NB22: a workaround that allows to embed an unique ID into the diagnostic code intended originally to be reported in client.