[GH-6970] Adding a system property to disable the multi source file handling. #6974
Conversation
|
SETTING_EnableMultiSourceRoot=true
public static boolean DISABLE_MULTI_SOURCE_ROOT = !"true".equals(Bundle.SETTING_EnableMultiSourceRoot());
Edit: I overlooked the obvious .... |
|
Less radical suggestion: #6975 |
| @Messages({ | ||
| "SETTING_EnableMultiSourceRoot=false" | ||
| }) | ||
| public class MultiSourceRootProvider implements ClassPathProvider { | ||
|
|
||
| public static boolean DISABLE_MULTI_SOURCE_ROOT = false; | ||
| public static boolean DISABLE_MULTI_SOURCE_ROOT = !"true".equals(Bundle.SETTING_EnableMultiSourceRoot()); |
There was a problem hiding this comment.
@matthiasblaesing this is the NB default which is inverted false -> disable is set to true.
the property is the branding for the LSP server which I suppose is for the VSCode use case (which enables it by default).
this is how I understand this at least - I could be wrong.
There was a problem hiding this comment.
Ah crap - yeah - overlooked that
There was a problem hiding this comment.
Does this work correctly if someone translates the messages?
Should we also add "true" to @Messages?
There was a problem hiding this comment.
@junichi11 not everything which is in property files is a user facing String. This is just a field which can be true or false - thats it. This is not going to be translated.
@Messages is just a mechanism to pull some properties into the code, since maintaining property files can be error prone.
|
We should use |
Most usage has been [GH-****] However, while this is being pointed out, the most useful thing is to make sure the issue is linked in the description. I've edited here. Issue references from titles don't work get automatically cross referenced. |
|
even if this isn't merged as-is, a slightly modified version of this could be useful as additional safety net to #6975 feature would be enabled by default but could be disabled via |
neilcsmith-net
added
the
do not merge
|
Am inclined to agree with @mbien to have a kill switch via system property. Less inclined to agree with merging later - would be better in rc2 IMO. |
|
Ok. I'll work on changing this to a system property. Thanks! |
lahodaj
force-pushed
the
NETBEANS-6970
branch
2 times, most recently
from
24a91cf
to
f94483f
Compare
lahodaj
force-pushed
the
NETBEANS-6970
branch
from
f94483f
to
3d9ce2f
Compare
|
Changed to a system property. To disable the multi source file handling, use: |
|
Assuming you meant |
Right. Copied from the wrong command line. |
mbien
changed the title
neilcsmith-net
removed
the
do not merge
neilcsmith-net
changed the title
mbien
added
the
Java
I think the caption says it all. Not only won't the source root be registered, they won't even be computed by default. Which should basically eliminate the effect of the multi source root feature.
Relates to #6970