Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a README for the bitmap-to-SVG icon process, plus Illustrator file and icon scripts #7465

Closed
wants to merge 1 commit into from

Conversation

eirikbakke
Copy link
Contributor

@eirikbakke eirikbakke commented Jun 13, 2024

This PR documents the process for drawing and installing scalable SVG versions of NetBeans icons, and commits the Illustrator File and script that was used to assemble icons in the separate PRs #7463.

Details:

  • Add a README file which documents the process for drawing and installing scalable SVG versions of the many old bitmap icons that are present in the NetBeans UI.
  • Add the Adobe Illustrator file with the around 70 icons that have been drawn to date. This Illustrator file also contains template artboards for icons that should be prioritized in the future. There's a PDF version of the Illustrator file for those who wish to have a look at it without installing Illustrator.
  • Add the IconTasks script, which is used to find, organize, and install icons in the NetBeans repo.
  • Add a HTML page summary of the icons and mappings to old bitmaps, generated by the IconTasks script. (The HTML page summary icons.html includes image references to SVG files that are committed in a separate PR, so it will have broken image links until that PR is merged as well. I have put a hosted version with working images here: https://people.csail.mit.edu/ebakke/misc/netbeans-icons-240612.html )

@eirikbakke eirikbakke added Platform [ci] enable platform tests (platform/*) UI User Interface labels Jun 13, 2024
Details:
* Add a README file which documents the process for drawing and installing scalable SVG versions of the many old bitmap icons that are present in the NetBeans UI.
* Add the Adobe Illustrator file with the around 70 icons that have been drawn to date. This Illustrator file also contains template artboards for icons that should be prioritized in the future. There's a PDF version of the Illustrator file for those who wish to have a look at it without installing Illustrator.
* Add the script, IconTasks that was used to find, organize, and install icons.
* Add a HTML page summary of the icons and mappings to old bitmaps, generated by the IconTasks script.
  (The HTML page summary includes references to SVG files that are committed in a separate PR, so it will have broken image links until then. I have put a hosted version with working images here:
  https://people.csail.mit.edu/ebakke/misc/netbeans-icons-240612.html )
@neilcsmith-net
Copy link
Member

Thanks for looking at this. The other PR looks great from a glance. This part I wonder whether should be added to https://github.com/apache/netbeans-tools instead?

@eirikbakke
Copy link
Contributor Author

eirikbakke commented Jun 13, 2024

This part I wonder whether should be added to https://github.com/apache/netbeans-tools instead?

Ah, that one seems like a better location; I wasn't entirely sure where to put the script. Though if there's ever a chance of the script becoming part of the official build process, then leaving it in this repo would make the git history cleaner.

Potential future changes that might be relevant to whether the script might eventually become a part of the build process:

  • Perhaps we decide that it's better to copy in the SVGs at build time, to avoid having lots of of duplicate SVGs committed in the repo? Or perhaps not; there were other ideas floated before that did not involve a build step, such as having a centralized icon substitution mechanism in ImageUtilities.
  • Perhaps we revisit the idea of generating PNGs of different resolutions (e.g. someicon@2x.png, someicon@1.5x.png) from the SVGs at build time instead of relying on the rather heavyweight NetBeans SVG loader. There are some use cases where SVGs won't load automatically, such as in image tags in a Swing HTML caption of a JLabel, or in image loading code generated by the NetBeans form builder.

Happy to open a PR against netbeans-tools instead if you think that's the best place for these files. Let me know what you think.

@neilcsmith-net
Copy link
Member

Happy to open a PR against netbeans-tools instead if you think that's the best place for these files.

It think it might be, but let's see what others think - cc/ @mbien @ebarboni @matthiasblaesing

Perhaps we revisit the idea of generating PNGs of different resolutions ... from the SVGs at build time instead of relying on the rather heavyweight NetBeans SVG loader.

Possibly. Another option might be to switch to a lighter-weight loader. Something for discussion elsewhere, perhaps mailing list, but interesting to see FlatLaf change to JSVG (as has IntelliJ) JFormDesigner/FlatLaf#664 https://github.com/weisJ/jsvg

@matthiasblaesing
Copy link
Contributor

Happy to open a PR against netbeans-tools instead if you think that's the best place for these files.

It think it might be, but let's see what others think - cc/ @mbien @ebarboni @matthiasblaesing

If this not tied into the build process, I would keep outside the main project and indeed that was my first though when seeing this PR.

@neilcsmith-net neilcsmith-net added the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Jul 19, 2024
@mbien
Copy link
Member

mbien commented Jul 23, 2024

Happy to open a PR against netbeans-tools instead if you think that's the best place for these files.

It think it might be, but let's see what others think - cc/ @mbien @ebarboni @matthiasblaesing

+1 for the tools repo. If possible without the PDF for two reasons: pdfs can do too much to be in code repos IMO and secondly: it would have to be kept in sync with the illustrator file, no?

@mbien
Copy link
Member

mbien commented Jul 23, 2024

btw I could open the .ai file with inkscape and everything seemed to show up, "New Vector" and "Old Bitpmaps" layers etc

@eirikbakke
Copy link
Contributor Author

Thanks for your comments; I have now revised the script to work from the netbeans-tools repo instead, and opened a PR there: apache/netbeans-tools#67

@eirikbakke eirikbakke closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Don't merge this PR, it is not ready or just demonstration purposes. Platform [ci] enable platform tests (platform/*) UI User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants