-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a README for the bitmap-to-SVG icon process, plus Illustrator file and icon scripts #7465
Conversation
46923a1
to
75bdfbb
Compare
Details: * Add a README file which documents the process for drawing and installing scalable SVG versions of the many old bitmap icons that are present in the NetBeans UI. * Add the Adobe Illustrator file with the around 70 icons that have been drawn to date. This Illustrator file also contains template artboards for icons that should be prioritized in the future. There's a PDF version of the Illustrator file for those who wish to have a look at it without installing Illustrator. * Add the script, IconTasks that was used to find, organize, and install icons. * Add a HTML page summary of the icons and mappings to old bitmaps, generated by the IconTasks script. (The HTML page summary includes references to SVG files that are committed in a separate PR, so it will have broken image links until then. I have put a hosted version with working images here: https://people.csail.mit.edu/ebakke/misc/netbeans-icons-240612.html )
75bdfbb
to
69d222d
Compare
Thanks for looking at this. The other PR looks great from a glance. This part I wonder whether should be added to https://github.com/apache/netbeans-tools instead? |
Ah, that one seems like a better location; I wasn't entirely sure where to put the script. Though if there's ever a chance of the script becoming part of the official build process, then leaving it in this repo would make the git history cleaner. Potential future changes that might be relevant to whether the script might eventually become a part of the build process:
Happy to open a PR against netbeans-tools instead if you think that's the best place for these files. Let me know what you think. |
It think it might be, but let's see what others think - cc/ @mbien @ebarboni @matthiasblaesing
Possibly. Another option might be to switch to a lighter-weight loader. Something for discussion elsewhere, perhaps mailing list, but interesting to see FlatLaf change to JSVG (as has IntelliJ) JFormDesigner/FlatLaf#664 https://github.com/weisJ/jsvg |
If this not tied into the build process, I would keep outside the main project and indeed that was my first though when seeing this PR. |
+1 for the tools repo. If possible without the PDF for two reasons: pdfs can do too much to be in code repos IMO and secondly: it would have to be kept in sync with the illustrator file, no? |
btw I could open the |
Thanks for your comments; I have now revised the script to work from the netbeans-tools repo instead, and opened a PR there: apache/netbeans-tools#67 |
This PR documents the process for drawing and installing scalable SVG versions of NetBeans icons, and commits the Illustrator File and script that was used to assemble icons in the separate PRs #7463.
Details: