-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shield against NPE in VSCode #7466
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
sdedic
approved these changes
Jun 17, 2024
dbalek
approved these changes
Jun 18, 2024
mklaehn
reviewed
Jun 18, 2024
Comment on lines
+2004
to
+2010
errors = errorProviders.stream().flatMap(provider -> { | ||
List<? extends org.netbeans.api.lsp.Diagnostic> errorsOrNull = provider.computeErrors(context); | ||
if (errorsOrNull == null) { | ||
errorsOrNull = Collections.emptyList(); | ||
} | ||
return errorsOrNull.stream(); | ||
}).collect(Collectors.toList()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I'd encode the desired behaviour in the stream operation directly but what you have will work too
Suggested change
errors = errorProviders.stream().flatMap(provider -> { | |
List<? extends org.netbeans.api.lsp.Diagnostic> errorsOrNull = provider.computeErrors(context); | |
if (errorsOrNull == null) { | |
errorsOrNull = Collections.emptyList(); | |
} | |
return errorsOrNull.stream(); | |
}).collect(Collectors.toList()); | |
errors = errorProviders.stream() | |
.map(provider -> provider.computeErrors(context)) | |
.filter(Object::nonNull) | |
.flatMap(List::stream) | |
.collect(Collectors.toList()); |
mklaehn
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are experiencing NPE when running Enso VSCode extension:
after some debugging I found that the code in TextDocumentServiceImpl added by Dušan four months ago and the code written by Sváťa two years ago disagree on whether a
null
is valid return type or not which leads toNullPointerException
.This PR is fixing that by checking for
null
on the caller side.