Fix an 'illegal reflective access' warning on startup #7476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the warning below, which was observed when starting a NetBeans Platform application: WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.openide.util.RequestProcessor$TopLevelThreadGroup (file:/C:/Users/ebakke/.m2/repository/org/netbeans/api/org-openide-util/RELEASE180ULT7/org-openide-util-RELEASE180ULT7.jar) to method sun.awt.AppContext.getAppContext() WARNING: Please consider reporting this to the maintainers of org.openide.util.RequestProcessor$TopLevelThreadGroup WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release
eirikbakke
added
Platform
There was a problem hiding this comment.
Wouldn't it make sense to remove the code completely? Even when considering developments like OpenWebStart, I assume, that the developers from OWS do the sane thing and don't try to share the same java process for multiple executions. Thus this indeed is mood.
|
Yeah, I can remove it. I have a habit of keeping old code around until it actually gets in the way, but this one is unlikely to ever be needed again. |
…mmit before merging.)
eirikbakke
force-pushed
the
pr-illreflwarn
branch
from
546b0e4
to
17159a1
Compare
mbien
approved these changes
Jun 21, 2024
|
Thanks for reviewing! Merging... |
|
forgot to squash :) |
|
D'oh, sorry about that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the warning below, which was observed when starting a NetBeans Platform application: