Upgrade to nb-javac from JDK 23, build 30

[lahodaj]

A draft for now, but if/when tests are OK with this version of javac, I think we should include it. (And, eventually, upgrade to a newer version when it becomes available, of course.)

[mbien]

goodbye string templates, lets hope they will be back at some point in future.

This is something we should mention on the download page since it might be surprising for users that NB 23 won't know about STs anymore even when the project is on JDK 21.

[lahodaj]

goodbye string templates, lets hope they will be back at some point in future.

This is something we should mention on the download page since it might be surprising for users that NB 23 won't know about STs anymore even when the project is on JDK 21.

Agreed. Although I don't see anything we could reasonably technically do to mitigate the situation.

[mbien]

Although I don't see anything we could reasonably technically do to mitigate the situation.

agreed. String templates were API+language and implemented in java.base and jdk.compiler. So even when we would create a frankenstein nb-javac and partially revert openjdk/jdk#18688 it would create problems.
We also don't know how the next version of string templates will look like or when it will arrive - as soon it is available it would break the JDK 21 templates anyway. (preview features are locked to the JDK version for a reason - otherwise the JDK would have to provide multiple implementations of the same feature)

This is the simplest approach, so +1 from me. Thanks for working on this!

[mbien]

changes look good, left a few comments inline

ran a smoke test and NB worked fine with nb-javac 23+26.

before merge, don't forget to:

• switch the staged dependencies to a release build
• squash as you see fit

adding do-not-merge label just to be sure!

[matthiasblaesing]

@lahodaj would you mind finalizing this? While looking into the JSF modules in the NetBeans codebase I also got exceptions from the ThisEscapeAnalyser and I have some hopes, that they are fixed by the update of nb-javac. I would test this one, but the referenced binaries seem not to have been released and thus were not promoted to central, so the nb-javac release has to be respun.

[matthiasblaesing]

Build a local test version of nb-javac and build netbeans with this applied: build.patch.txt

First impression is good, I plan to run with it the next week.

[lahodaj]

The plan is to finalize with a new (currently up-to-date) javac. Ideally, sometime during this week, I think. Thanks for the comments!

[mbien]

this PR would have to bump the two 22 values to 23-ea for the java hints job like we did in past a few times:

netbeans/.github/workflows/main.yml

Lines 1465 to 1468 in 76e1f35

	java: [ '17', '22' ]
	config: [ 'batch1', 'batch2' ]
	exclude:
	- java: ${{ github.event_name == 'pull_request' && 'nothing' || '22' }}

this would allow us to merge #7525 without having to wait for the nb-javac changes.

[lahodaj]

The nb-javac binary download has been updated to JDK 23 build 30, as uploaded to Maven central, I think I've fixed all the comments so far. So I think this is ready for review now. Thanks!

[dbalek]

Looks fine to me.

[mbien]

looks good! Please don't forget to squash as you see fit.

[lahodaj]

Thanks! I'll merge if there's a clean test run.

[mbien]

had to restart the platform batch2 and groovy jobs, but the failures look like normal flakiness unrelated to nb-javac. Should be green in a few minutes.