-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-2923 Add expression language support to Kerberos parameters used… #1148
Conversation
Thank you for contributing. In addition to adding the expressionLanguageSupported flag on the property descriptors, we would also need to go through the code and find every place where the properties are evaluated, for example: And that would need to call evaluateAttributeExpressions(). |
Thank you for your feedback, I will add the necessary call to evaluateAttributeExpressions(). |
If you still encounter issues in UI when testing properties while using expression language, please check that nifi.kerberos.krb5.file is correctly set in your nifi.properties file (and reference a readable file). In addition, it would be great to do the same kind of modification in Kafka processors where Kerberos principal is also a property. Let me know if you are OK to do it, otherwise, I'll do it. Thanks! |
@mauriziocolleluori thank you for the contribution. any intent on addressing @pvillard31 's comment? While a positive answer is more than welcome, a negative answer is also welcome... all we need to know is if this is ready to review or if you still plan to address the comments. Cheers! |
@trixpan @pvillard31 thank you for you comments. I will look into the Kafka processors and revert back once it's done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR is looking good but that new tests were added to the affected processors
Would that be possible?
Cheers
@mauriziocolleluori Hello, and thank you for your contribution! I am working on a JIRA (https://issues.apache.org/jira/browse/NIFI-4010) that builds upon the changes in your PR. Could you please address the remaining comments to help get your PR committed? |
@mauriziocolleluori I've cherry-picked your commits into my branch, and will be submitting a PR that includes your commits along with mine (for NIFI-4010). Thank you for your contribution to Apache NiFi! When my PR is merged to master, your PR will be closed along with mine. |
…DFS processor properties FetchSFTP/ListSFTP/PutSFTP: Private Key Path ListHDFS/FetchHDFS/PutHDFS/DeleteHDFS: Hadoop Configuration Resources, Kerberos Principal, Kerberos Keytab, Kerberos Relogin Period This closes apache#1148
…DFS processor properties FetchSFTP/ListSFTP/PutSFTP: Private Key Path ListHDFS/FetchHDFS/PutHDFS/DeleteHDFS: Hadoop Configuration Resources, Kerberos Principal, Kerberos Keytab, Kerberos Relogin Period This closes apache#1148
…DFS processor properties FetchSFTP/ListSFTP/PutSFTP: Private Key Path ListHDFS/FetchHDFS/PutHDFS/DeleteHDFS: Hadoop Configuration Resources, Kerberos Principal, Kerberos Keytab, Kerberos Relogin Period This closes apache#1148
…DFS processor properties FetchSFTP/ListSFTP/PutSFTP: Private Key Path ListHDFS/FetchHDFS/PutHDFS/DeleteHDFS: Hadoop Configuration Resources, Kerberos Principal, Kerberos Keytab, Kerberos Relogin Period This closes apache#1148
…DFS processor properties FetchSFTP/ListSFTP/PutSFTP: Private Key Path ListHDFS/FetchHDFS/PutHDFS/DeleteHDFS: Hadoop Configuration Resources, Kerberos Principal, Kerberos Keytab, Kerberos Relogin Period This closes apache#1148
…DFS processor properties FetchSFTP/ListSFTP/PutSFTP: Private Key Path ListHDFS/FetchHDFS/PutHDFS/DeleteHDFS: Hadoop Configuration Resources, Kerberos Principal, Kerberos Keytab, Kerberos Relogin Period This closes apache#1148 This closes apache#1930. Signed-off-by: Bryan Bende <bbende@apache.org>
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
in the commit message?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
… by processors