NIFI-1930 Updated ListenHTTP to set TLS included protocols #4687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
NIFI-1930 Updated ListenHTTP to configure the Jetty SslContextFactory with included protocols based on the configuration of the SSLContextService TLS Protocol property. The Jetty SslContextFactory will be configured to support multiple current TLS protocol versions when the TLS Protocol is configured without a specific version. When the SSLContextService TLS Protocol property specifies a particular TLS Protocol version, only that version will be allowed.
This update simplifies the configuration of the Jetty SslContextFactory by using the SSLContext created from SSLContextService, as opposed to passing the individual key store and trust store properties. This update also introduces a new Client Auth property for ListenHTTP to explicitly define the TLS client authentication policy. Previous versions of ListenHTTP inferred the client authentication policy based on the presence or absence of trust store properties in the SSLContextService. The Client Auth property is defaulted to REQUIRED to support mutual TLS authentication, but all standard values are supported.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main
)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squash
or use--force
when pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean install
at the rootnifi
folder?LICENSE
file, including the mainLICENSE
file undernifi-assembly
?NOTICE
file, including the mainNOTICE
file found undernifi-assembly
?.displayName
in addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.