NIFI-9501 Add REST end-point to retrieve a RuntimeManifest #5630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This looks straightforward overall @bbende, just noted a few questions.
...nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/FlowResource.java
Show resolved
Hide resolved
...ork/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/controller/ControllerFacade.java
Outdated
Show resolved
Hide resolved
...ork/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/controller/ControllerFacade.java
Outdated
Show resolved
Hide resolved
- Switch ExtensionManifestParser impl to use JAXB instead of Jackson XML - Fix handling of older NARs that don't have newer fields in ExtensionManifest
…ons-lang3 from c2 dependencies
|
@exceptionfactory any chance you can take another pass at this? I think I have addressed the previous comments with the latest commit |
exceptionfactory
approved these changes
Jan 21, 2022
There was a problem hiding this comment.
Thanks @bbende, verified the current version, looks good! +1 Merging.
krisztina-zsihovszki
pushed a commit
to krisztina-zsihovszki/nifi
that referenced
this pull request
Jun 28, 2022
- Switch ExtensionManifestParser implementation to use JAXB instead of Jackson XML - Fix handling of older NARs that don't have newer fields in ExtensionManifest - Add response merging for runtime-manifest REST end-point, remove commons-lang3 from c2 dependencies This closes apache#5630 Signed-off-by: David Handermann <exceptionfactory@apache.org>
Lehel44
pushed a commit
to Lehel44/nifi
that referenced
this pull request
Jul 1, 2022
- Switch ExtensionManifestParser implementation to use JAXB instead of Jackson XML - Fix handling of older NARs that don't have newer fields in ExtensionManifest - Add response merging for runtime-manifest REST end-point, remove commons-lang3 from c2 dependencies This closes apache#5630 Signed-off-by: David Handermann <exceptionfactory@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.