NIFI-10701 Update MiNiFi docker base images to eclipse-temurin #6587
Conversation
briansolo1985
force-pushed
the
NIFI-10701_Update_MiNiFi_Base_Docker_Image
branch
from
780c167
to
5ba17c2
Compare
|
As openjdk images are deprecated and discontinued I updated the base images to eclipse-temurin which can be considered as a successor of the openjdk line. |
| @@ -16,13 +16,13 @@ | |||
| # under the License. | |||
| # | |||
|
|
|||
| FROM openjdk:8-jre-alpine | |||
| FROM eclipse-temurin:8-jre | |||
There was a problem hiding this comment.
I think it is good this way just wanted to double check whether it would make sense to pin the exact version as this way we get the latest and we can get "silent" java updates which could cause problems (at least I faced an issue on a previous project because of this). Again I think we are good and this is how it was earlier just wanted to double check.
There was a problem hiding this comment.
Yes I think it's beneficial to have the latest version for every build even though as you said there is a risk that a new Java version will cause issues. Would keep it as it is if no objections.
There was a problem hiding this comment.
I think I'm ok with this given it should not be being built frequently. I noticed the same about the apt-get update && ... command, but on the whole, I think the benefits are worth it. We can revisit if it becomes a problem.
| @@ -47,17 +46,17 @@ This can be accomplished through: | |||
| The following example shows the usage of two volumes to provide both a `config.yml` and a `bootstrap.conf` to the container instance. This makes use of configuration files on the host and maps them to be used by the MiNiFi instance. This is helpful in scenarios where a single image is used for a variety of configurations. | |||
|
|
|||
| docker run -d \ | |||
| -v ~/minifi-conf/config.yml:/opt/minifi/minifi-0.5.0/conf/config.yml \ | |||
| -v ~/minifi-conf/bootstrap.conf:/opt/minifi/minifi-0.5.0/conf/bootstrap.conf \ | |||
| apache/nifi-minifi:0.5.0 | |||
There was a problem hiding this comment.
Quite a big jump in versions :)
|
Thanks for the contribution @briansolo1985 and for the help reviewing @bejancsaba @ferencerdei. I should be able to complete my review soon |
There was a problem hiding this comment.
Thanks for putting this together @briansolo1985! The change from the unsupported OpenJDK image to the current Eclipse Temurin JDK looks good. That is one of the two JDK versions used for regular GitHub Actions, so it makes sense as a base image.
There was a problem hiding this comment.
Nice work @briansolo1985! The code changes look good, and I had a chance to try it out.
- I did a dockermaven build and verified the resulting images
- I tested dockerhub builds using 1.18.0
- I tested dockerhub builds for arm64 using the process you shared with me. This will be a nice addition for the community!
All worked great! I opened NIFI-10820 to track doing a similar update to the base image for nifi, registry, etc. That should be easy following what you have done here for minifi and minifi-c2. Thanks!
+1, merging to main.
|
Merged in commit 709110da35f4f2cc91a916d0663742c594cba126 |
Summary
NIFI-10701
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation