NIFI-11224 - FF attribute support in Where condition of QuerySalesforceObject

[pvillard31]

Summary

NIFI-11224

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

• Apache NiFi Jira issue created

Pull Request Tracking

• Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
• Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

• Pull Request based on current revision of the main branch
• Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

• Build completed using mvn clean install -P contrib-check
  • JDK 11
  • JDK 17

Licensing

• New dependencies are compatible with the Apache License 2.0 according to the License Policy
• New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

• Documentation formatting appears as expected in rendered files

[mark-bathori]

I think the null check for the FlowFile would be still needed here, so it would be better to move that check condition outside from the isCustomQuery check.

[pvillard31]

Thanks for the review, since we do want to evaluate EL wether the FlowFile is null or not, I added a null check in the processQuery part.

[Lehel44]

I recommend removing flowfile == null check before the condition. Based on @markap14 answer in case of processors annotated with @TriggerSerially this check is not necessary. However if a processor can have multiple executing thread, the following can happen:

"

• 1 FlowFile in queue and 2 threads start running.
• Thread 1 calls session.get() and gets the only FlowFile.
• Then Thread 2 calls session.get() and gets back a null."

The flowfile is optional and the null check will be handled in the processQuery and processCustomQuery methods.

[mark-bathori]

Thank you for the improvements @pvillard31
+1 LGTM